Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datasets): Sanitizing /save response #17579

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

craig-rueda
Copy link
Member

@craig-rueda craig-rueda commented Nov 30, 2021

SUMMARY

Ensures a default dict will always be included in dataset saves. Needed to prevent a few edge cases.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #17579 (93fb828) into master (bfba4f1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 93fb828 differs from pull request most recent head f023cc5. Consider uploading reports for the commit f023cc5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17579      +/-   ##
==========================================
- Coverage   77.01%   76.99%   -0.02%     
==========================================
  Files        1049     1049              
  Lines       56683    56688       +5     
  Branches     7852     7852              
==========================================
- Hits        43652    43645       -7     
- Misses      12778    12790      +12     
  Partials      253      253              
Flag Coverage Δ
hive 81.61% <100.00%> (+<0.01%) ⬆️
mysql ?
postgres 82.04% <100.00%> (+<0.01%) ⬆️
presto 81.90% <100.00%> (+<0.01%) ⬆️
python 82.49% <100.00%> (-0.04%) ⬇️
sqlite 81.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 76.92% <100.00%> (-0.51%) ⬇️
superset/views/datasource/views.py 90.21% <100.00%> (+0.10%) ⬆️
superset/views/utils.py 82.26% <100.00%> (+0.45%) ⬆️
superset/db_engine_specs/mysql.py 94.04% <0.00%> (-3.58%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfba4f1...f023cc5. Read the comment docs.

@craig-rueda craig-rueda merged commit ac76def into apache:master Nov 30, 2021
@craig-rueda craig-rueda deleted the craig/sanitize-save branch November 30, 2021 04:07
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Nov 30, 2021
@sadpandajoe
Copy link
Member

🏷️ 2021.44

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Nov 30, 2021
eschutho pushed a commit that referenced this pull request Dec 8, 2021
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.44 preset-io size/S v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants