Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sqllab): Hover tooltip flashes in SQL Lab #17068

Merged
merged 3 commits into from
Oct 14, 2021
Merged

fix(sqllab): Hover tooltip flashes in SQL Lab #17068

merged 3 commits into from
Oct 14, 2021

Conversation

lyndsiWilliams
Copy link
Member

@lyndsiWilliams lyndsiWilliams commented Oct 12, 2021 •
edited
Loading

SUMMARY

In FilterableTable, changing each Tooltip implementation's display to block and the placement to "topLeft" fixed this.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE

before

AFTER

tooltipAfter

TESTING INSTRUCTIONS

Hover over the column header of any SQL Lab result query and observe that the tooltip no longer flashes.

ADDITIONAL INFORMATION

  • Has associated issue: Janky animation when you hover over a column header in SQL Lab results #16824
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 12, 2021 •
edited
Loading

Codecov Report

Merging #17068 (0092041) into master (c2e1ab6) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0092041 differs from pull request most recent head 1288c27. Consider uploading reports for the commit 1288c27 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17068      +/-   ##
==========================================
- Coverage   76.88%   76.87%   -0.02%     
==========================================
  Files        1031     1031              
  Lines       55183    55192       +9     
  Branches     7505     7506       +1     
==========================================
+ Hits        42430    42431       +1     
- Misses      12501    12509       +8     
  Partials      252      252
Flag Coverage Δ
javascript 70.79% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/components/FilterableTable/FilterableTable.tsx 81.86% <ø> (ø)
superset-frontend/src/components/Tooltip/index.tsx 100.00% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 71.91% <0.00%> (-1.94%) ⬇️
...-frontend/src/datasource/ChangeDatasourceModal.tsx 86.36% <0.00%> (-1.14%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 66.29% <0.00%> (+0.37%) ⬆️
...perset-frontend/src/datasource/DatasourceModal.tsx 75.38% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e1ab6...1288c27. Read the comment docs.

@eschutho
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://54.184.78.102:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

betodealmeida
betodealmeida approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyndsiWilliams
Copy link
Member Author

lyndsiWilliams commented Oct 13, 2021 •
edited
Loading

🏷️ #Hacktoberfest-accepted

@eschutho
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://34.217.212.108:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho eschutho added the hold:testing! On hold for testing label Oct 13, 2021
@eschutho
Copy link
Member

/testenv up FEATURE_ALERT_REPORTS=true

@eschutho
Copy link
Member

@rosemarie-chiu can we test other instances of tooltips since this is a global change? Thanks!

@eschutho
Copy link
Member

_DEV__Superset
I think I found where this broke something on alerts and reports. I'm trying to spin up a new testenv with that feature enabled for testing.

@github-actions
Copy link
Contributor

@eschutho Ephemeral environment spinning up at http://34.217.6.22:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@eschutho
Copy link
Member

@yousoph for testing

@eschutho eschutho merged commit 635898a into apache:master Oct 14, 2021
@eschutho eschutho removed the hold:testing! On hold for testing label Oct 14, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@lyndsiWilliams lyndsiWilliams deleted the lyndsi/16824-hover-tooltip-fix branch October 14, 2021 23:48
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@lyndsiWilliams
fix(sqllab): Hover tooltip flashes in SQL Lab (apache#17068)
042e406 
* Changed SQL Lab result column header-style width to max-content

* Changed .ant-tooltip-open to block and tooltip placement to topLeft

* Moved tooltip style changes to local implementation instead of global
@eschutho eschutho added the v1.4 label Nov 23, 2021
eschutho pushed a commit that referenced this pull request Nov 23, 2021
@lyndsiWilliams @eschutho
fix(sqllab): Hover tooltip flashes in SQL Lab (#17068)
b577773 
* Changed SQL Lab result column header-style width to max-content

* Changed .ant-tooltip-open to block and tooltip placement to topLeft

* Moved tooltip style changes to local implementation instead of global

(cherry picked from commit 635898a)
@mistercrunch mistercrunch added 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho left review comments

@AAfghahi AAfghahi AAfghahi approved these changes

@betodealmeida betodealmeida betodealmeida approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S v1.4 🍒 1.4.0 🍒 1.4.1 🍒 1.4.2 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lyndsiWilliams @eschutho @betodealmeida @AAfghahi @mistercrunch