chore(Dashboard): Disable save button in Native Filters when an error is present #17037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgabryje
reviewed
Oct 8, 2021
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/Footer/Footer.tsx
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #17037 +/- ##
==========================================
- Coverage 76.91% 76.91% -0.01%
==========================================
Files 1039 1039
Lines 55568 55572 +4
Branches 7570 7571 +1
==========================================
+ Hits 42742 42744 +2
- Misses 12576 12578 +2
Partials 250 250
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…e/native-filters-disable-save
…e/native-filters-disable-save
michael-s-molina
approved these changes
Oct 18, 2021
…e/native-filters-disable-save
eschutho
pushed a commit
that referenced
this pull request
Oct 27, 2021
… is present (#17037) * Disable save on error * Remove removed erroredFilter * Fix cdisabled check
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
… is present (apache#17037) * Disable save on error * Remove removed erroredFilter * Fix cdisabled check
mistercrunch
added
🍒 1.4.0
🍒 1.4.1
🍒 1.4.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR disabled the save button when an error is present in the native filters as it was suggested in this comment #16940 (review)
AFTER
COVID.Vaccine.Da.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION