fix: Verify when null value should be undefined in Select

[geido]

SUMMARY

This PR fixes an edge case with the Select component. With dynamic controls there might be the case where a default value is being passed as null when it was intended to be undefined. This change makes sure that a null value that is not available in the options is considered asundefined instead.

BEFORE

AFTER

TESTING INSTRUCTIONS

1. Create a Histogram chart
2. Observe the Columns control

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[geido]

@michael-s-molina for clarity, this is just a safety check for now. Ideally, we should go through each configuration object of the SelectControl in superset and superset-ui and remove the default value when it's null but it's meant to be undefined. I can do that in separate PRs.

[michael-s-molina]

@michael-s-molina for clarity, this is just a safety check for now. Ideally, we should go through each configuration object of the SelectControl in superset and superset-ui and remove the default value when it's null but it's meant to be undefined. I can do that in separate PRs.

@geido Can't this check/conversion be made in SelectControl?

[geido]

For reference, we have agreed with Michael that this safety check will be done in SelectControl and SelectAsyncControl as those are the components where this problem might happen more often. I am about to update this PR.

[geido]

@michael-s-molina I just updated the PR. Please have a look

[michael-s-molina]

LGTM

[codecov]

Codecov Report

Merging #17013 (3be175a) into master (9e980b6) will decrease coverage by 0.00%.
The diff coverage is 76.92%.

❗ Current head 3be175a differs from pull request most recent head a5aabfb. Consider uploading reports for the commit a5aabfb to get more accurate results

@@            Coverage Diff             @@
##           master   #17013      +/-   ##
==========================================
- Coverage   76.94%   76.93%   -0.01%     
==========================================
  Files        1030     1030              
  Lines       55088    55098      +10     
  Branches     7480     7484       +4     
==========================================
+ Hits        42385    42392       +7     
- Misses      12452    12455       +3     
  Partials      251      251              

Flag	Coverage Δ
javascript	70.90% <76.92%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../src/explore/components/controls/SelectControl.jsx	77.61% <75.00%> (-1.08%)	⬇️
...e/components/controls/SelectAsyncControl/index.tsx	80.48% <80.00%> (-0.60%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e980b6...a5aabfb. Read the comment docs.

[AAfghahi]

🏷 v1.4