-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom filters control #17006
feat: Custom filters control #17006
Conversation
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
Codecov Report
@@ Coverage Diff @@
## master #17006 +/- ##
==========================================
- Coverage 76.71% 76.71% -0.01%
==========================================
Files 1030 1031 +1
Lines 55035 55185 +150
Branches 7465 7513 +48
==========================================
+ Hits 42221 42334 +113
- Misses 12565 12600 +35
- Partials 249 251 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://34.220.40.242:8080. Credentials are |
...rset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
Outdated
Show resolved
Hide resolved
...rset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Down the road we might also want to introduce a concept of sections that should be enabled, as the metric control is very similar and has the Saved, Simple and Custom SQL (we might very well introduce saved filters later in the dataset). So instead of enableCustomSQL
, enableSimple
etc we could have sections = [SAVED, SIMPLE, CUSTOM_SQL]
.
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/index.jsx
Outdated
Show resolved
Hide resolved
...rset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
Outdated
Show resolved
Hide resolved
...t-frontend/src/explore/components/controls/FilterControl/AdhocFilterPopoverTrigger/index.tsx
Outdated
Show resolved
Hide resolved
@geido @michael-s-molina @villebro fixed according notes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with an optional improvement for legacy Druid
...rset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
Show resolved
Hide resolved
...rset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/index.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for implementing the druid thing 👍
Ephemeral environment shutdown and build artifacts deleted. |
* fix:fix get permission function * feat: customize filter control * fix: fix types * fix: fix merge * refactor: update according CR * refactor: fix CR notes (cherry picked from commit eebc953)
* fix:fix get permission function * feat: customize filter control * fix: fix types * fix: fix merge * refactor: update according CR * refactor: fix CR notes
For some customer needs we needs customize AdHocFilters control to be more dynamic according needs (please review video), it includes:
Custom SQL
tabHere example of our custom configuration:
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-10-07.at.10.59.15.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION