fix: ensure known dashboard id is used in save first

[pkdotson]

SUMMARY

This pr fixes an issue where the user will get save selection for the wrong dashboard in save chart modal.

after

Screen.Recording.2021-10-06.at.4.57.42.PM.mov

TESTING INSTRUCTIONS

Go to dashboard and change controls and hit run. Ensure that dashboard is the dashboard the chart is saving from

ADDITIONAL INFORMATION

• [ x] Has associated issue: Fixes [explore] severe regression: ADD TO DASHBOARD refers to wrong chart origin dashboard #16964
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16998 (1f33cbd) into master (40861b3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #16998   +/-   ##
=======================================
  Coverage   76.85%   76.85%           
=======================================
  Files        1030     1030           
  Lines       55031    55031           
  Branches     7465     7465           
=======================================
  Hits        42294    42294           
  Misses      12483    12483           
  Partials      254      254           

Flag	Coverage Δ
javascript	70.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...rset-frontend/src/explore/components/SaveModal.tsx	86.81% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40861b3...1f33cbd. Read the comment docs.

[geido]

Code LGTM! Thanks for the fix!

[villebro]

LGTM, but tagging @michael-s-molina for review as he added this line in #12125

[michael-s-molina]

@pkdotson I found this while testing:

Screen.Recording.2021-10-07.at.7.51.48.AM.mov

On master, when you enter in Explore for the second time and click save, the dashboard is not empty but also it's not the correct one. So it seems we're still missing something to fix this.

[pkdotson]

/testenv up

[github-actions]

@pkdotson Ephemeral environment spinning up at http://34.215.178.157:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[pkdotson]

@pkdotson I found this while testing:

Screen.Recording.2021-10-07.at.7.51.48.AM.mov
On master, when you enter in Explore for the second time and click save, the dashboard is not empty but also it's not the correct one. So it seems we're still missing something to fix this.

Yes this is the correct behavior when you not a owner of the chart.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.