Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check npm lockfile version #16916

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Sep 30, 2021

SUMMARY

Add checking of npm lockfile version to CI to avoid flip-flopping between versions 1 and 2.

SCREENSHOTS/TESTING

When things go right:
image

When things go wrong:
image

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #16916 (bc5982e) into master (331de0c) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head bc5982e differs from pull request most recent head c8eb640. Consider uploading reports for the commit c8eb640 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16916      +/-   ##
==========================================
- Coverage   77.03%   77.02%   -0.01%     
==========================================
  Files        1021     1021              
  Lines       54846    54846              
  Branches     7481     7481              
==========================================
- Hits        42248    42247       -1     
- Misses      12351    12352       +1     
  Partials      247      247              
Flag Coverage Δ
javascript 71.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 88.46% <0.00%> (-0.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 331de0c...c8eb640. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement!

@villebro villebro merged commit 77e7d16 into apache:master Sep 30, 2021
@villebro villebro deleted the villebro/ci-npm-lock-check branch September 30, 2021 08:43
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants