-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(native_filter): feature on by default #16874
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16874 +/- ##
==========================================
- Coverage 77.05% 76.90% -0.15%
==========================================
Files 1021 1021
Lines 54693 54693
Branches 7457 7457
==========================================
- Hits 42141 42059 -82
- Misses 12307 12389 +82
Partials 245 245
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - rerunning tests to see if it's just flakiness or if some tests need updating
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets do this!
SUMMARY
This PR is making Dashboard Native_Filter on by default. User will be able to access to this feature without configuring going forward. This feature has been throughout tested and is ready for prime time. In fact, without this feature being visible, user may hit bugs when trying to use the legacy Filterbox along or with Native filter at the same time. This change will also drive users away from using Filterbox which has been causing errors.
NOTE: We will remove this FF for good in about 1 month.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

### TESTING INSTRUCTIONS NAADDITIONAL INFORMATION