Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrades Storybook to version 6.3.8 to make it compatible with Webpack 5 #16857

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

#16701 migrated Webpack to version 5. This PR upgrades the Storybook to version 6.3.8 to make it compatible with the new Webpack version.

TESTING INSTRUCTIONS

  • Open the Storybook
  • All stories should be working

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #16857 (946238c) into master (f703c12) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16857      +/-   ##
==========================================
+ Coverage   76.93%   76.97%   +0.03%     
==========================================
  Files        1021     1021              
  Lines       54708    54693      -15     
  Branches     7459     7457       -2     
==========================================
+ Hits        42092    42098       +6     
+ Misses      12372    12350      -22     
- Partials      244      245       +1     
Flag Coverage Δ
javascript 71.19% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-frontend/src/components/Select/NativeSelect.tsx 70.00% <0.00%> (-10.00%) ⬇️
...rontend/src/components/Select/DeprecatedSelect.tsx 80.39% <0.00%> (-1.97%) ⬇️
...d/src/explore/components/PropertiesModal/index.tsx 80.28% <0.00%> (-1.67%) ⬇️
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 68.33% <0.00%> (-1.03%) ⬇️
...rset-frontend/src/explore/components/SaveModal.tsx 86.81% <0.00%> (-0.29%) ⬇️
...ponents/controls/TimeSeriesColumnControl/index.jsx 92.00% <0.00%> (+0.21%) ⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 73.87% <0.00%> (+0.60%) ⬆️
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 16.12% <0.00%> (+0.97%) ⬆️
...trol/AdhocFilterEditPopoverSqlTabContent/index.jsx 62.50% <0.00%> (+1.20%) ⬆️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 83.46% <0.00%> (+3.31%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f703c12...946238c. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this, LGTM!

@michael-s-molina michael-s-molina merged commit 27a40d2 into apache:master Sep 27, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants