Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gallery): Hide the bottom info section when no chart is being selected #16840

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR improve the viz gallery that hide the bottom info section when no chart is being selected.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

2021-09-25.4.46.09.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: [Gallery]Hide the bottom info section when no chart is being selected #16771
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #16840 (2a06b61) into master (a341319) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16840   +/-   ##
=======================================
  Coverage   77.00%   77.00%           
=======================================
  Files        1018     1018           
  Lines       54687    54688    +1     
  Branches     7461     7463    +2     
=======================================
+ Hits        42112    42113    +1     
  Misses      12331    12331           
  Partials      244      244           
Flag Coverage Δ
javascript 71.12% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 94.85% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a341319...2a06b61. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review September 27, 2021 07:20
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the improvement.

@zhaoyongjie zhaoyongjie merged commit 100760c into apache:master Sep 27, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants