fix: Normalise *.sh File Endings
#16608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows users encounter problems running the `docker-compose` commands to run an instance of Superset. The reason for this is line-endings for the `*.sh` files that are mounted and used in the `command` sections for the superset images. Many Windows users will check the repository out with line endings set to `CRLF`. When mounted in to the *nix-based containers, these line endings are not understood, leading to errors such as: ```text /usr/bin/env: bash\r: No such file or directory ``` The addition of a `.gitattributes` file resolves this issue by telling git to always resolve these files with `LF` line endings. +semver: fix +ref: #10132
|
I wasn't sure if a |
|
/testenv up |
|
@suddjian Container image not yet published for this PR. Please try again when build is complete. |
|
@suddjian Ephemeral environment creation failed. Please check the Actions logs for details. |
|
/testenv up |
|
@suddjian Ephemeral environment spinning up at http://54.188.58.11:8080. Credentials are |
suddjian
approved these changes
Sep 13, 2021
|
Ephemeral environment shutdown and build artifacts deleted. |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
Windows users encounter problems running the `docker-compose` commands to run an instance of Superset. The reason for this is line-endings for the `*.sh` files that are mounted and used in the `command` sections for the superset images. Many Windows users will check the repository out with line endings set to `CRLF`. When mounted in to the *nix-based containers, these line endings are not understood, leading to errors such as: ```text /usr/bin/env: bash\r: No such file or directory ``` The addition of a `.gitattributes` file resolves this issue by telling git to always resolve these files with `LF` line endings. +semver: fix +ref: apache#10132
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
Windows users encounter problems running the `docker-compose` commands to run an instance of Superset. The reason for this is line-endings for the `*.sh` files that are mounted and used in the `command` sections for the superset images. Many Windows users will check the repository out with line endings set to `CRLF`. When mounted in to the *nix-based containers, these line endings are not understood, leading to errors such as: ```text /usr/bin/env: bash\r: No such file or directory ``` The addition of a `.gitattributes` file resolves this issue by telling git to always resolve these files with `LF` line endings. +semver: fix +ref: apache#10132
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Windows users encounter problems running the
docker-composecommandsto run an instance of Superset.
The reason for this is line-endings for the
*.shfiles that aremounted and used in the
commandsections for the superset images.Many Windows users will check the repository out with line endings set
to
CRLF. When mounted in to the *nix-based containers, these lineendings are not understood, leading to errors such as:
The addition of a
.gitattributesfile resolves this issue by tellinggit to always resolve these files with
LFline endings.fixes #10132
ADDITIONAL INFORMATION