chore: Merges latest Select changes #16587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
commented
Sep 3, 2021
| @@ -416,6 +427,7 @@ const Select = ({ | |||
| allowNewOptions, | |||
| initialOptions, | |||
| isSingleMode, | |||
| onChange, | |||
There was a problem hiding this comment.
@geido onChange was not in the list of dependencies in your original PR. It's a good idea to check that you're passing a memoized function 😉
michael-s-molina
commented
Sep 3, 2021
| | 'notFoundContent' | ||
| | 'onChange' | ||
| | 'onClear' | ||
| | 'onFocus' |
There was a problem hiding this comment.
@geido I didn't add defaultValue assuming that we can use value.
Codecov Report
@@ Coverage Diff @@
## master #16587 +/- ##
=======================================
Coverage 76.71% 76.71%
=======================================
Files 1002 1002
Lines 53823 53832 +9
Branches 7287 7293 +6
=======================================
+ Hits 41292 41299 +7
- Misses 12291 12293 +2
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Merges latest
Selectchanges made in #16483, #16393, and #16510.TESTING INSTRUCTIONS
All tests should pass.
ADDITIONAL INFORMATION