Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Select component refactoring - MetricControl - Iteration 5 #16423

Merged
merged 10 commits into from
Sep 27, 2021
Merged

chore: Select component refactoring - MetricControl - Iteration 5 #16423

merged 10 commits into from
Sep 27, 2021

Conversation

geido
Copy link
Member

@geido geido commented Aug 24, 2021 •
edited
Loading

SUMMARY

It replaces the react-select Select component with the Antdesign one in the MetricControl component.

BEFORE

DEV.Games.per.before.mp4

AFTER

DEV.Games.per.after.mp4

TESTING INSTRUCTIONS

  1. Open Explore
  2. Add all different types of Metrics

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido geido added the risk:refactor High risk as it involves large refactoring work label Aug 24, 2021
@geido geido marked this pull request as ready for review August 24, 2021 16:18
@codecov
Copy link

codecov bot commented Aug 25, 2021 •
edited
Loading

Codecov Report

Merging #16423 (601a526) into master (88c09c2) will decrease coverage by 0.21%.
The diff coverage is 78.57%.

❗ Current head 601a526 differs from pull request most recent head 0c557df. Consider uploading reports for the commit 0c557df to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16423      +/-   ##
==========================================
- Coverage   76.98%   76.76%   -0.22%     
==========================================
  Files        1007     1007              
  Lines       54109    54106       -3     
  Branches     7369     7368       -1     
==========================================
- Hits        41655    41536     -119     
- Misses      12214    12330     +116     
  Partials      240      240
Flag Coverage Δ
hive ?
javascript 71.30% <84.61%> (+0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/webdriver.py 80.89% <0.00%> (-0.92%) ⬇️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 83.46% <84.61%> (+3.31%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.04% <0.00%> (-1.66%) ⬇️
superset/models/core.py 89.00% <0.00%> (-0.75%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 89.76% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c09c2...0c557df. Read the comment docs.

@geido
Merge branch 'master' of https://github.com/apache/superset into chor…
fd9686c 
…e/select-component-refactoring-metric-control-iteration-5
michael-s-molina
michael-s-molina approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. We can improve it by supplying human readable aria-labels.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 26, 2021
@geido
Copy link
Member Author

geido commented Aug 27, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://54.186.191.12:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido added the hold:testing! On hold for testing label Sep 10, 2021
@geido
Merge branch 'master' of https://github.com/apache/superset into chor…
05cee4c 
…e/select-component-refactoring-metric-control-iteration-5
@geido geido removed the hold:testing! On hold for testing label Sep 15, 2021
@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://52.34.23.243:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

michael-s-molina
michael-s-molina approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkdotson
pkdotson approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the changes!

@geido geido merged commit 913df18 into apache:master Sep 27, 2021
@geido geido deleted the chore/select-component-refactoring-metric-control-iteration-5 branch September 27, 2021 14:26
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@geido
chore: Select component refactoring - MetricControl - Iteration 5 (ap…
d3ddae7 
…ache#16423)

* Refactor Select

* Render saved metric option

* Update tests

* Fix Cypress and ariaLabels

* Fix lint

* Lint Cypress

* Reconcile with latest Select changes
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@geido
chore: Select component refactoring - MetricControl - Iteration 5 (ap…
9b38b09 
…ache#16423)

* Refactor Select

* Render saved metric option

* Update tests

* Fix Cypress and ariaLabels

* Fix lint

* Lint Cypress

* Reconcile with latest Select changes
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@pkdotson pkdotson pkdotson approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@zhaoyongjie zhaoyongjie Awaiting requested review from zhaoyongjie

@junlincc junlincc Awaiting requested review from junlincc

@villebro villebro Awaiting requested review from villebro

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@etr2460 etr2460 Awaiting requested review from etr2460

@ktmud ktmud Awaiting requested review from ktmud

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:refactor High risk as it involves large refactoring work size/L test_priority:high 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@geido @michael-s-molina @pkdotson @mistercrunch @junlincc