Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove mergepoint from past migration #16301

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

etr2460
Copy link
Member

@etr2460 etr2460 commented Aug 17, 2021

SUMMARY

We try to keep a single branch of all migrations, and this specific migration refers to 2 different down revisions. ae1ed299413b was merged multiple weeks before this migration, and also has a child migration already, so removing it from the chain here should be safe

TESTING INSTRUCTIONS

CI. CI should go through a superset db upgrade and will error if something is broken here

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

to: @betodealmeida @pkdotson @john-bodley
cc: @michellethomas

@etr2460 etr2460 requested a review from a team as a code owner August 17, 2021 22:12
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe, since the migrations are not dependent.

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #16301 (46cb35c) into master (ac8e54d) will not change coverage.
The diff coverage is n/a.

❗ Current head 46cb35c differs from pull request most recent head 41c7f9a. Consider uploading reports for the commit 41c7f9a to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16301   +/-   ##
=======================================
  Coverage   76.43%   76.43%           
=======================================
  Files         999      999           
  Lines       53394    53394           
  Branches     6817     6817           
=======================================
  Hits        40813    40813           
  Misses      12344    12344           
  Partials      237      237           
Flag Coverage Δ
mysql 81.66% <ø> (+0.04%) ⬆️
postgres 81.69% <ø> (ø)
python 81.77% <ø> (ø)
sqlite 81.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac8e54d...41c7f9a. Read the comment docs.

@etr2460 etr2460 merged commit d5f63a7 into master Aug 17, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the erik-ritter--fix-mergepoint branch March 26, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants