refactor: re-arrange dashboard page js bundles #16285
Conversation
| @@ -21,7 +21,7 @@ | |||
| with development version #} | |||
| <!-- Bundle js {{ filename }} START --> | |||
| {% for entry in js_manifest(filename) %} | |||
| <script src="{{ entry }}"></script> | |||
| <script src="{{ entry }}" async></script> | |||
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## master #16285 +/- ##
==========================================
- Coverage 76.49% 76.28% -0.21%
==========================================
Files 997 997
Lines 53246 53244 -2
Branches 6777 6777
==========================================
- Hits 40731 40619 -112
- Misses 12285 12395 +110
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
graceguo-supercat
changed the title
graceguo-supercat
requested review from
nytai and
suddjian
and removed request for
nytai
|
/testenv up |
|
@suddjian Ephemeral environment spinning up at http://54.184.98.240:8080. Credentials are |
|
Ephemeral environment shutdown and build artifacts deleted. |
|
@graceguo-supercat VizType filter values are now missing on the Charts page. Could this be related? |
mistercrunch
added
🏷️ bot
SUMMARY
I am trying to rearrange existing bundles needed by the dashboard page, make spa.js execute and route to the dashboard page quicker, so that it can start to fetch dashboard metadata earlier.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
CI and manual test
Note:
The perf improvement is hard to estimate, because I only run a few times, with same dashboard, from my own computer. I feel it might be highly impacted by my computer's performance. For example if i was in zoom meeting the page load will be slower 😂
Since the change is relatively small, I hope could deploy to airbnb production environment and collect some real data. If thing didn't work well, i am ok to roll it back.
cc @nytai and @suddjian I saw you have a lot of work on spa and recent dashboard refactor, please take a look at this PR.
also cc @ktmud and @etr2460