chore(pylint): Reenable too-few-public-methods check

[john-bodley]

SUMMARY

Re-enabling the Pylint too-few-public-methods check.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

• Has associated issue: [SIP-46] Proposal for strict Pylint enforcement #9953
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16264 (7aa9ece) into master (7b72443) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #16264   +/-   ##
=======================================
  Coverage   76.47%   76.48%           
=======================================
  Files         997      997           
  Lines       53245    53238    -7     
  Branches     6777     6774    -3     
=======================================
- Hits        40720    40718    -2     
+ Misses      12295    12290    -5     
  Partials      230      230           

Flag	Coverage Δ
mysql	81.56% <100.00%> (ø)
postgres	81.55% <100.00%> (-0.05%)	⬇️
python	81.67% <100.00%> (ø)
sqlite	81.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/dashboards/api.py	93.03% <ø> (ø)
superset/datasets/api.py	91.92% <ø> (ø)
superset/commands/base.py	100.00% <100.00%> (ø)
superset/common/query_context.py	90.74% <100.00%> (ø)
superset/dashboards/commands/importers/v1/utils.py	80.59% <100.00%> (ø)
superset/databases/schemas.py	98.38% <100.00%> (ø)
superset/examples/multiformat_time_series.py	16.66% <100.00%> (ø)
superset/extensions.py	92.68% <100.00%> (ø)
superset/utils/encrypt.py	88.00% <100.00%> (ø)
superset/utils/pandas_postprocessing.py	84.80% <100.00%> (ø)
... and 7 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c7ed9...7aa9ece. Read the comment docs.

[villebro]

This rule would be great if it didn't trigger when the class name ends in Mixin or similar. I'm not sure of the need for re-enabling this rule - any particular reason we'd want this other than going with defaults?

[john-bodley]

@villebro I agree that there are cases where we want to disable this, but again it's there to help ensure people aren't using a class as a container when a dataclass, namedtuple or similar would be suffice, or maybe using a method.

[villebro]

@villebro I agree that there are cases where we want to disable this, but again it's there to help ensure people aren't using a class as a container when a dataclass, namedtuple or similar would be suffice, or maybe using a method.

@john-bodley ok fair enough 👍