Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reverting Dataset names #16243

Merged
merged 2 commits into from
Aug 17, 2021
Merged

Conversation

AAfghahi
Copy link
Member

SUMMARY

This reverts the dataset names changed here: #16183

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #16243 (ca09fd5) into master (1715143) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

❗ Current head ca09fd5 differs from pull request most recent head a47089a. Consider uploading reports for the commit a47089a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16243      +/-   ##
==========================================
- Coverage   76.71%   76.60%   -0.11%     
==========================================
  Files         996      996              
  Lines       53152    53152              
  Branches     6771     6771              
==========================================
- Hits        40775    40717      -58     
- Misses      12147    12205      +58     
  Partials      230      230              
Flag Coverage Δ
hive ?
mysql 81.53% <0.00%> (ø)
postgres 81.59% <0.00%> (+0.04%) ⬆️
presto 81.39% <0.00%> (ø)
python 81.86% <0.00%> (-0.22%) ⬇️
sqlite 81.19% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/bart_lines.py 27.58% <0.00%> (ø)
superset/examples/deck.py 12.50% <0.00%> (ø)
superset/examples/energy.py 26.19% <0.00%> (ø)
superset/examples/flights.py 17.64% <0.00%> (ø)
superset/examples/long_lat.py 23.80% <0.00%> (ø)
superset/examples/sf_population_polygons.py 26.92% <0.00%> (ø)
superset/examples/world_bank.py 30.55% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/connectors/sqla/models.py 89.46% <0.00%> (-0.24%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1715143...a47089a. Read the comment docs.

@eschutho eschutho merged commit 4119bb9 into apache:master Aug 17, 2021
@eschutho eschutho deleted the arash/revertDashboards branch August 17, 2021 19:16
eschutho added a commit to preset-io/superset that referenced this pull request Aug 23, 2021
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 25, 2021
This reverts commit 4119bb9.

(cherry picked from commit 3feb9d3)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* reverting dataset name changes

* remove extra quotes

Co-authored-by: Elizabeth Thompson <[email protected]>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* reverting dataset name changes

* remove extra quotes

Co-authored-by: Elizabeth Thompson <[email protected]>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants