Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Changing Dataset names #16199

Merged
merged 10 commits into from
Aug 11, 2021
Merged

feat: Changing Dataset names #16199

merged 10 commits into from
Aug 11, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

We are renaming many datasets in superset based on user feedback that some of the current datasets are confusing and hard to understand.

This should improve the overall experience that a new user has in superset.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi force-pushed the ch21810_DatasetNames branch 4 times, most recently from bbef29f to a4d5411 Compare August 11, 2021 15:17
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 11, 2021
@AAfghahi AAfghahi force-pushed the ch21810_DatasetNames branch from a4d5411 to 4868327 Compare August 11, 2021 15:21
eschutho
eschutho approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@AAfghahi AAfghahi force-pushed the ch21810_DatasetNames branch from 4868327 to 3306411 Compare August 11, 2021 15:29
@AAfghahi AAfghahi force-pushed the ch21810_DatasetNames branch from 3306411 to 7d6b806 Compare August 11, 2021 15:32
@codecov
Copy link

codecov bot commented Aug 11, 2021 •
edited
Loading

Codecov Report

Merging #16199 (7d6b806) into master (98fc29c) will decrease coverage by 0.21%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16199      +/-   ##
==========================================
- Coverage   76.82%   76.61%   -0.22%     
==========================================
  Files         996      996              
  Lines       53060    53062       +2     
  Branches     6766     6767       +1     
==========================================
- Hits        40764    40651     -113     
- Misses      12068    12183     +115     
  Partials      228      228
Flag Coverage Δ
hive ?
javascript 71.18% <ø> (+<0.01%) ⬆️
mysql 81.61% <0.00%> (+0.04%) ⬆️
postgres 81.59% <0.00%> (-0.05%) ⬇️
presto ?
python 81.72% <0.00%> (-0.43%) ⬇️
sqlite 81.27% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/examples/bart_lines.py 27.58% <0.00%> (ø)
superset/examples/deck.py 12.50% <0.00%> (ø)
superset/examples/flights.py 17.64% <0.00%> (ø)
superset/examples/long_lat.py 23.80% <0.00%> (ø)
superset/examples/sf_population_polygons.py 26.92% <0.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.49%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.03% <0.00%> (-1.66%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98fc29c...7d6b806. Read the comment docs.

@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

@eschutho eschutho merged commit 6c304b8 into apache:master Aug 11, 2021
@eschutho eschutho deleted the ch21810_DatasetNames branch August 11, 2021 16:00
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021
@AAfghahi
feat: Changing Dataset names (apache#16199)
adb3ebb 
* added google alert

* changing Dataset Names

(cherry picked from commit 6c304b8)
@AAfghahi
Copy link
Member Author

@eschutho does this one need to be reversed?

@eschutho
Copy link
Member

yes it does

AAfghahi added a commit to preset-io/superset that referenced this pull request Aug 12, 2021
@AAfghahi
Revert "feat: Changing Dataset names (apache#16199)"
359030d 
This reverts commit adb3ebb.
eschutho pushed a commit that referenced this pull request Aug 12, 2021
@AAfghahi
Revert "feat: Changing Dataset names (#16199)" (#16235)
9d0dc56 
This reverts commit adb3ebb.
@villebro villebro added the v1.3 label Aug 16, 2021
villebro pushed a commit that referenced this pull request Aug 16, 2021
@AAfghahi @villebro
feat: Changing Dataset names (#16199)
185eaf7 
* added google alert

* changing Dataset Names

(cherry picked from commit 6c304b8)
amitmiran137 pushed a commit that referenced this pull request Aug 16, 2021
Merge remote-tracking branch 'upstream/master' into feat/extra_strate…
202704a 
…gies

* upstream/master: (64 commits)
  check roles before fetching reports (#16260)
  chore: upgrade mypy and add type guards (#16227)
  fix: pivot columns with ints for name (#16259)
  chore(pylint): Bump Pylint to 2.9.6 (#16146)
  fix examples tab for dashboard (#16253)
  chore: bump superset-ui packages to 0.17.84 (#16251)
  chore: Shows the dataset description in the gallery dropdown (#16200)
  fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168)
  chore: bump py version for integration test (#16213)
  fix: skip perms on query context update (#16250)
  refactor: external metadata fetch API (#16193)
  feat(dao): admin can remove self from object owners (#15149)
  fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233)
  fix: validate_parameters and query (#16241)
  fix: Remove Advanced Analytics tag for 2 charts (#16240)
  Revert "feat: Changing Dataset names (#16199)" (#16235)
  feat: Allow users to connect via legacy SQLA form (#16201)
  fix: remove encryption from db params (#16214)
  fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060)
  Show/hide tooltips (#16192)
  ...

# Conflicts:
#	superset/tasks/caching/cache_strategy.py
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 25, 2021
@AAfghahi
feat: Changing Dataset names (apache#16199)
a235f5b 
* added google alert

* changing Dataset Names

(cherry picked from commit 6c304b8)
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 25, 2021
@AAfghahi
feat: Changing Dataset names (apache#16199)
66a4919 
* added google alert

* changing Dataset Names

(cherry picked from commit 6c304b8)
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 25, 2021
@AAfghahi
feat: Changing Dataset names (apache#16199)
3bffbb3 
* added google alert

* changing Dataset Names

(cherry picked from commit 6c304b8)
(cherry picked from commit a235f5b)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@AAfghahi
feat: Changing Dataset names (apache#16199)
4ea2961 
* added google alert

* changing Dataset Names
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@AAfghahi
Revert "feat: Changing Dataset names (apache#16199)" (apache#16235)
099ea09 
This reverts commit adb3ebb.
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@AAfghahi
feat: Changing Dataset names (apache#16199)
d805391 
* added google alert

* changing Dataset Names

(cherry picked from commit 6c304b8)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@AAfghahi
feat: Changing Dataset names (apache#16199)
203b73d 
* added google alert

* changing Dataset Names
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@AAfghahi
Revert "feat: Changing Dataset names (apache#16199)" (apache#16235)
d6c0895 
This reverts commit adb3ebb.
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@AAfghahi @villebro
feat: Changing Dataset names (apache#16199)
6b86a66 
* added google alert

* changing Dataset Names

(cherry picked from commit 6c304b8)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@AAfghahi
feat: Changing Dataset names (apache#16199)
2556a5b 
* added google alert

* changing Dataset Names

(cherry picked from commit b9329a8)
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eschutho eschutho eschutho approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/M v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AAfghahi @rosemarie-chiu @eschutho @mistercrunch @villebro