Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pylint reenable bad-option-value message #15775

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jul 19, 2021

SUMMARY

Re-enabling the Pylint bad-option-value message.

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-46] Proposal for strict Pylint enforcement #9953
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #15775 (fc32dfe) into master (ca873ac) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15775      +/-   ##
==========================================
- Coverage   76.92%   76.91%   -0.01%     
==========================================
  Files         983      983              
  Lines       51624    51624              
  Branches     6994     6994              
==========================================
- Hits        39710    39708       -2     
- Misses      11691    11693       +2     
  Partials      223      223              
Flag Coverage Δ
hive 81.28% <100.00%> (ø)
mysql 81.54% <100.00%> (ø)
postgres 81.56% <100.00%> (ø)
presto 81.27% <100.00%> (-0.01%) ⬇️
python 82.09% <100.00%> (-0.01%) ⬇️
sqlite 81.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/commands/importers/v1/examples.py 40.90% <ø> (ø)
...erset/dashboards/commands/importers/v1/__init__.py 98.50% <ø> (ø)
superset/utils/mock_data.py 24.81% <ø> (ø)
superset/datasets/dao.py 96.62% <100.00%> (ø)
superset/db_engine_specs/presto.py 89.89% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca873ac...fc32dfe. Read the comment docs.

@john-bodley john-bodley changed the title chore: pylint reenable bad-option-value chore: Pylint reenable bad-option-value Jul 19, 2021
@john-bodley john-bodley changed the title chore: Pylint reenable bad-option-value chore: Pylint reenable bad-option-value message Jul 19, 2021
@john-bodley john-bodley requested a review from etr2460 July 19, 2021 06:02
@john-bodley john-bodley merged commit 32a5680 into apache:master Jul 21, 2021
@john-bodley john-bodley deleted the john-bodley--pylint-reenable-bad-option-value branch July 21, 2021 16:34
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants