Make Sqllab a one-page app -- body not scrollable #1551
Conversation
|
Won't that make it impossible to see the bottom of the panes? |
|
The user could reach the bottom of panes by scrolling the right editor. I thought we want left-bar and right-panel to be scrollable independently, If both parts are scrollable and user could reach the bottom of all the content it should be fine? |
|
I tried this version and I can't reach the bottom of either pane while scrolling. |
|
Ahh I see. I added a container and content as we have in explorev2 and now it is working. I'm not a css expert so I'm not sure if there's a better way. So far this approach seems clearer than calculating tab-size and navbar size dynamically. |
| bottom: 0px; | ||
| overflow: scroll; | ||
| margin-right: 0px; | ||
| margin-bottom: 100px; |
There was a problem hiding this comment.
where's that 100px coming from? Is it to offset the navbar + tabbar?
There was a problem hiding this comment.
I think it's just the margin between panel/left-bar and bottom of browser window, in case they are too close and look like being cutoff
|
@vera-liu rebase plz |
vera-liu
force-pushed
the
vliu_sqllab_nonscrollable
branch
from
c3e1a94 to
7f19904
Compare
vera-liu
force-pushed
the
vliu_sqllab_nonscrollable
branch
from
7f19904 to
c4a31e5
Compare
mistercrunch
added
🏷️ bot
Previously I made left-bar and right-panel scrollable in sqllab https://github.com/airbnb/caravel/pull/1532#pullrequestreview-6951086
however it introduced two scroll bars on the right (one for App one for right panel). I am making App non-scrollable in this PR, so that user can only scroll left-bar and right-panel.
needs-review @mistercrunch