fix: actually write changes on "superset import-datasources"

[regisb]

SUMMARY

When running the following command:

superset import-datasources --path=datasource.json

the data stored in "datasources.json" may either be dict or a list. In the case
of a dataset exported from a live superset instance, it is a list. When it is
re-imported, the SqlaTable.import_from_dict utility method is used. This
method does not commit changes to the database, so the imported datasets are
never saved to the database, causing frustration and sadness.

TESTING INSTRUCTIONS

1. Create and export dataset
2. Change the name of the dataset in the exported file
3. Re-import dataset

Prior to the fix, the new dataset is not created.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[regisb]

Auto-closing a PR without a single comment or feedback from project maintainers in a year? Come on, that's not very nice. Is it because the importer migrated to v1? As far as I know, the issue that this PR resolves is still present in importer v0.

[rusackas]

I see this PR is still open (despite StaleBot's empty threats). Obviously, this has been sitting around for a long while, which I also apologize for... please advise on whether or not this is still important to merge, and maybe we can finally get it that review.

[regisb]

Thanks for the response @rusackas. At the time, the PR did seem important. I'm not so sure that it is still important, but I'm pretty sure that the bug is still there. So I would suggest to merge this PR.

[regisb]

Rebased on top of master. I'm still hoping this will be merged in 2024 😛

[rusackas]

Running CI 🤞 Here's hoping it'll turn green :D

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.75%. Comparing base (76d897e) to head (2e1e0f6).
Report is 1094 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #14817       +/-   ##
===========================================
+ Coverage   60.48%   83.75%   +23.26%     
===========================================
  Files        1931      518     -1413     
  Lines       76236    37624    -38612     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31512    -14602     
+ Misses      28017     6112    -21905     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	48.90% <0.00%> (-0.26%)	⬇️
javascript	?
mysql	77.27% <100.00%> (?)
postgres	77.40% <100.00%> (?)
presto	53.51% <0.00%> (-0.30%)	⬇️
python	83.75% <100.00%> (+20.26%)	⬆️
sqlite	76.85% <100.00%> (?)
unit	59.20% <0.00%> (+1.58%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[regisb]

Unfortunately I no longer have time to setup a dev environment for Superset, and thus I am unable to add unit tests to this PR.

[regisb]

Thanks for merging this PR!

[rusackas]

Thanks for the PR! Sorry it took approximately forever. We won't the next one slip through the cracks, I promise ;)