-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixes group by control icon colors #14674
fix: Fixes group by control icon colors #14674
Conversation
/testenv up |
@junlincc Container image not yet published for this PR. Please try again when build is complete. |
@junlincc Ephemeral environment creation failed. Please check the Actions logs for details. |
Codecov Report
@@ Coverage Diff @@
## master #14674 +/- ##
=======================================
Coverage 77.54% 77.54%
=======================================
Files 958 958
Lines 48541 48534 -7
Branches 5702 5702
=======================================
- Hits 37640 37636 -4
+ Misses 10700 10698 -2
+ Partials 201 200 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks for the fix!
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.220.93.217:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fixes group by control icon colors.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
@rusackas @junlincc @kgabryje
TEST PLAN
1 - Go to explore
2 - Add a measure, filter and group by
3 - The icons should all look the same
ADDITIONAL INFORMATION