Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up a debug line from #11653 #11663

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Nov 12, 2020

SUMMARY

Clean up a debug line that accidentally slipped through in #11653

cc @dpgaspar

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Nov 12, 2020

Codecov Report

Merging #11663 (a9d5493) into master (2718909) will increase coverage by 4.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11663      +/-   ##
==========================================
+ Coverage   62.36%   66.57%   +4.21%     
==========================================
  Files         874      874              
  Lines       42336    42344       +8     
  Branches     3972     3972              
==========================================
+ Hits        26402    28190    +1788     
+ Misses      15754    14056    -1698     
+ Partials      180       98      -82     
Flag Coverage Δ
cypress 55.24% <ø> (?)
javascript 62.85% <ø> (ø)
python 61.97% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/mysql.py 79.59% <0.00%> (-12.25%) ⬇️
superset/db_engine_specs/sqlite.py 65.62% <0.00%> (-9.38%) ⬇️
superset/utils/celery.py 82.14% <0.00%> (-3.58%) ⬇️
...et-frontend/src/SqlLab/components/LimitControl.tsx 89.36% <0.00%> (-1.95%) ⬇️
superset/result_set.py 96.69% <0.00%> (-1.66%) ⬇️
...ntend/src/views/CRUD/annotation/AnnotationList.tsx 77.17% <0.00%> (-0.85%) ⬇️
...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx 73.03% <0.00%> (-0.83%) ⬇️
superset/models/core.py 88.42% <0.00%> (-0.83%) ⬇️
superset/views/core.py 73.84% <0.00%> (-0.48%) ⬇️
superset/connectors/sqla/models.py 90.63% <0.00%> (-0.28%) ⬇️
... and 184 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2718909...a9d5493. Read the comment docs.

@ktmud ktmud merged commit 542d2e3 into apache:master Nov 12, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants