Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enabled pylint rules in db_engines module #11016

Merged
merged 1 commit into from
Sep 23, 2020
Merged

fix: enabled pylint rules in db_engines module #11016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions superset/db_engines/hive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,16 @@
from typing import Optional, TYPE_CHECKING

if TYPE_CHECKING:
from pyhive.hive import Cursor # pylint: disable=unused-import
from TCLIService.ttypes import TFetchOrientation # pylint: disable=unused-import
from pyhive.hive import Cursor
from TCLIService.ttypes import TFetchOrientation

# pylint: disable=protected-access
# TODO: contribute back to pyhive.
def fetch_logs(
self: "Cursor",
max_rows: int = 1024, # pylint: disable=unused-argument
_max_rows: int = 1024,
orientation: Optional["TFetchOrientation"] = None,
) -> str: # pylint: disable=unused-argument
) -> str:
"""Mocked. Retrieve the logs produced by the execution of the query.
Can be called multiple times to fetch the logs produced after
the previous call.
Expand All @@ -37,7 +37,7 @@ def fetch_logs(
"""
from pyhive import hive
from TCLIService import ttypes
from thrift import Thrift # pylint: disable=import-error
from thrift import Thrift

orientation = orientation or ttypes.TFetchOrientation.FETCH_NEXT
try:
Expand Down