fix(db-engine-spec): execute oracle DML statement bug in sqllab #10706

chuancyzhang · 2020-08-28T06:49:00Z

when i execute oracle sql statements like update in SQLLAB, get "oracle error: not a query" error.

Refer https://www.python.org/dev/peps/pep-0249/, superset old version use
cursor.description ，because this attribute will be None for operations that do not return rows or if the cursor has not had an operation invoked via the .execute*() method yet.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

when i execute oracle sql statements like update in SQLLAB, get "oracle error: not a query" error. Refer https://www.python.org/dev/peps/pep-0249/, superset old version use `cursor.description` ，because this attribute will be None for operations that do not return rows or if the cursor has not had an operation invoked via the .execute*() method yet.

villebro

Small comment, other than that LGTM!

superset/db_engine_specs/oracle.py

Co-authored-by: Ville Brofeldt <[email protected]>

superset/db_engine_specs/oracle.py

codecov-commenter · 2020-08-29T13:21:26Z

Codecov Report

Merging #10706 into master will increase coverage by 0.24%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #10706      +/-   ##
==========================================
+ Coverage   64.76%   65.00%   +0.24%     
==========================================
  Files         789      788       -1     
  Lines       37091    37175      +84     
  Branches     3555     3554       -1     
==========================================
+ Hits        24021    24166     +145     
+ Misses      12963    12902      -61     
  Partials      107      107

Flag	Coverage Δ
#cypress	`55.85% <ø> (+0.23%)`	⬆️
#javascript	`61.53% <ø> (+0.17%)`	⬆️
#python	`60.28% <50.00%> (+0.25%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/db_engine_specs/oracle.py	`81.25% <50.00%> (-7.64%)`	⬇️
superset-frontend/src/views/App.tsx	`32.35% <0.00%> (-25.55%)`	⬇️
superset/db_engine_specs/sqlite.py	`65.62% <0.00%> (-9.38%)`	⬇️
superset/db_engines/hive.py	`82.14% <0.00%> (-3.58%)`	⬇️
...ntend/src/dashboard/components/PublishedStatus.jsx	`61.90% <0.00%> (-1.74%)`	⬇️
superset/result_set.py	`96.69% <0.00%> (-1.66%)`	⬇️
...end/src/SqlLab/components/RunQueryActionButton.tsx	`68.18% <0.00%> (-1.39%)`	⬇️
superset-frontend/src/components/Menu/Menu.tsx	`94.93% <0.00%> (-1.15%)`	⬇️
superset/sql_lab.py	`78.26% <0.00%> (-0.44%)`	⬇️
...ontend/src/explore/components/QueryAndSaveBtns.jsx	`91.66% <0.00%> (-0.34%)`	⬇️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c715cad...bca16fa. Read the comment docs.

superset/db_engine_specs/oracle.py

Co-authored-by: Ville Brofeldt <[email protected]>

superset/db_engine_specs/oracle.py

Co-authored-by: Ville Brofeldt <[email protected]>

villebro

LGTM, thanks for the fix and your patience!

…he#10706) * fix execute oracle DML statement bug in sqllab when i execute oracle sql statements like update in SQLLAB, get "oracle error: not a query" error. Refer https://www.python.org/dev/peps/pep-0249/, superset old version use `cursor.description` ，because this attribute will be None for operations that do not return rows or if the cursor has not had an operation invoked via the .execute*() method yet. * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update oracle.py * Update oracle.py * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update superset/db_engine_specs/oracle.py Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>

* fix execute oracle DML statement bug in sqllab when i execute oracle sql statements like update in SQLLAB, get "oracle error: not a query" error. Refer https://www.python.org/dev/peps/pep-0249/, superset old version use `cursor.description` ，because this attribute will be None for operations that do not return rows or if the cursor has not had an operation invoked via the .execute*() method yet. * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update oracle.py * Update oracle.py * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update superset/db_engine_specs/oracle.py Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>

…he#10706) * fix execute oracle DML statement bug in sqllab when i execute oracle sql statements like update in SQLLAB, get "oracle error: not a query" error. Refer https://www.python.org/dev/peps/pep-0249/, superset old version use `cursor.description` ，because this attribute will be None for operations that do not return rows or if the cursor has not had an operation invoked via the .execute*() method yet. * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update oracle.py * Update oracle.py * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update superset/db_engine_specs/oracle.py Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>

* fix execute oracle DML statement bug in sqllab when i execute oracle sql statements like update in SQLLAB, get "oracle error: not a query" error. Refer https://www.python.org/dev/peps/pep-0249/, superset old version use `cursor.description` ，because this attribute will be None for operations that do not return rows or if the cursor has not had an operation invoked via the .execute*() method yet. * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update oracle.py * Update oracle.py * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update superset/db_engine_specs/oracle.py Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>

…he#10706) * fix execute oracle DML statement bug in sqllab when i execute oracle sql statements like update in SQLLAB, get "oracle error: not a query" error. Refer https://www.python.org/dev/peps/pep-0249/, superset old version use `cursor.description` ，because this attribute will be None for operations that do not return rows or if the cursor has not had an operation invoked via the .execute*() method yet. * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update oracle.py * Update oracle.py * Apply suggestions from code review Co-authored-by: Ville Brofeldt <[email protected]> * Update oracle.py * Update superset/db_engine_specs/oracle.py Co-authored-by: Ville Brofeldt <[email protected]> Co-authored-by: Ville Brofeldt <[email protected]>

pull-request-size bot added the size/S label Aug 28, 2020

villebro requested changes Aug 28, 2020

View reviewed changes

superset/db_engine_specs/oracle.py Outdated Show resolved Hide resolved

villebro changed the title ~~fix execute oracle DML statement bug in sqllab~~ fix(db-engine-spec): execute oracle DML statement bug in sqllab Aug 28, 2020

Apply suggestions from code review

7e70f0b

Co-authored-by: Ville Brofeldt <[email protected]>

villebro requested changes Aug 29, 2020

View reviewed changes

superset/db_engine_specs/oracle.py Outdated Show resolved Hide resolved

chuancyzhang added 2 commits August 29, 2020 21:04

Update oracle.py

b36590f

Update oracle.py

dae0dd3

Update oracle.py

f2c7b0f

villebro reviewed Aug 29, 2020

View reviewed changes

superset/db_engine_specs/oracle.py Outdated Show resolved Hide resolved

superset/db_engine_specs/oracle.py Outdated Show resolved Hide resolved

Apply suggestions from code review

bca16fa

Co-authored-by: Ville Brofeldt <[email protected]>

villebro reviewed Aug 29, 2020

View reviewed changes

superset/db_engine_specs/oracle.py Outdated Show resolved Hide resolved

Update oracle.py

c246fc2

villebro reviewed Aug 30, 2020

View reviewed changes

superset/db_engine_specs/oracle.py Outdated Show resolved Hide resolved

Update superset/db_engine_specs/oracle.py

cca6903

Co-authored-by: Ville Brofeldt <[email protected]>

villebro approved these changes Aug 31, 2020

View reviewed changes

villebro merged commit 234b6bb into apache:master Aug 31, 2020

villebro added v0.37.0 v0.37.1 and removed v0.37.0 labels Aug 31, 2020

villebro added v0.37 v0.37.2 and removed v0.37.1 labels Sep 6, 2020

dpgaspar added the v0.38 label Sep 9, 2020

chuancyzhang deleted the patch-3 branch July 27, 2021 02:56

mistercrunch added 🍒 0.37.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(db-engine-spec): execute oracle DML statement bug in sqllab #10706

fix(db-engine-spec): execute oracle DML statement bug in sqllab #10706

chuancyzhang commented Aug 28, 2020

villebro left a comment

codecov-commenter commented Aug 29, 2020 •

edited

Loading

villebro left a comment

fix(db-engine-spec): execute oracle DML statement bug in sqllab #10706

fix(db-engine-spec): execute oracle DML statement bug in sqllab #10706

Conversation

chuancyzhang commented Aug 28, 2020

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

villebro left a comment

Choose a reason for hiding this comment

codecov-commenter commented Aug 29, 2020 • edited Loading

Codecov Report

villebro left a comment

Choose a reason for hiding this comment

codecov-commenter commented Aug 29, 2020 •

edited

Loading