Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Clickhouse] [Feature Request] SQL editor autocomplete for functions and args #15477

Closed
asafcombo opened this issue Jun 30, 2021 · 1 comment · Fixed by #16234
Closed

[Clickhouse] [Feature Request] SQL editor autocomplete for functions and args #15477

asafcombo opened this issue Jun 30, 2021 · 1 comment · Fixed by #16234
Labels
data:connect:clickhouse Related to Clickhouse enhancement:request Enhancement request submitted by anyone from the community

Comments

@asafcombo
Copy link

I saw that this is currently only supported in hive connections (see below for reference).

This feature is important for data exploration purposes

superset/superset/db_engine_specs/hive.py

Line 508 in e466066

def get_function_names(cls, database: "Database") -> List[str]:

@junlincc junlincc added enhancement:request Enhancement request submitted by anyone from the community data:connect:clickhouse Related to Clickhouse labels Jul 1, 2021
@junlincc
Copy link
Member

junlincc commented Jul 1, 2021

@asafcombo we would love a contribution from the community 🙏😬

@junlincc junlincc closed this as completed Jul 1, 2021
@Slach Slach mentioned this issue Aug 12, 2021
Merged
Slach added a commit to Altinity/superset that referenced this issue Aug 20, 2021
@Slach
add function list to auto-complete to Clickhouse datasource, fix apac…
327ccdb 
…he#15477

Signed-off-by: Slach <[email protected]>
Slach added a commit to Altinity/superset that referenced this issue Aug 20, 2021
@Slach
add function list to auto-complete to Clickhouse datasource, fix apac…
afd63bd 
…he#15477

fix review comments apache#16234 (comment)

Signed-off-by: Slach <[email protected]>
zhaoyongjie pushed a commit that referenced this issue Aug 26, 2021
@Slach
feat: add function list to auto-complete to Clickhouse datasource (#1…
1badcae 
…6234)

* add function list to auto-complete to Clickhouse datasource, fix #15477

Signed-off-by: Slach <[email protected]>

* add function list to auto-complete to Clickhouse datasource, fix #15477
fix review comments #16234 (comment)

Signed-off-by: Slach <[email protected]>

* fix CI/CD https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235776 and https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235707

Signed-off-by: Slach <[email protected]>

* fix black formatting

Signed-off-by: Slach <[email protected]>

* fix isort pre-commit hook

Signed-off-by: Slach <[email protected]>
opus-42 pushed a commit to opus-42/incubator-superset that referenced this issue Nov 14, 2021
@Slach
feat: add function list to auto-complete to Clickhouse datasource (ap…
b4e9223 
…ache#16234)

* add function list to auto-complete to Clickhouse datasource, fix apache#15477

Signed-off-by: Slach <[email protected]>

* add function list to auto-complete to Clickhouse datasource, fix apache#15477
fix review comments apache#16234 (comment)

Signed-off-by: Slach <[email protected]>

* fix CI/CD https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235776 and https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235707

Signed-off-by: Slach <[email protected]>

* fix black formatting

Signed-off-by: Slach <[email protected]>

* fix isort pre-commit hook

Signed-off-by: Slach <[email protected]>
QAlexBall pushed a commit to QAlexBall/superset that referenced this issue Dec 28, 2021
@Slach
feat: add function list to auto-complete to Clickhouse datasource (ap…
2de16e5 
…ache#16234)

* add function list to auto-complete to Clickhouse datasource, fix apache#15477

Signed-off-by: Slach <[email protected]>

* add function list to auto-complete to Clickhouse datasource, fix apache#15477
fix review comments apache#16234 (comment)

Signed-off-by: Slach <[email protected]>

* fix CI/CD https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235776 and https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235707

Signed-off-by: Slach <[email protected]>

* fix black formatting

Signed-off-by: Slach <[email protected]>

* fix isort pre-commit hook

Signed-off-by: Slach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:connect:clickhouse Related to Clickhouse enhancement:request Enhancement request submitted by anyone from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add function list to auto-complete to Clickhouse datasource Altinity/superset
2 participants
@asafcombo @junlincc