address pre-commit checks

apache · Jan 31, 2025 · eb3ddcf · eb3ddcf
1 parent 5d19e0d
commit eb3ddcf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/superset/db_engine_specs/parseable.py b/superset/db_engine_specs/parseable.py
@@ -26,13 +26,15 @@
 
 if TYPE_CHECKING:
     from superset.connectors.sqla.models import TableColumn
+    from superset.models.core import Database
 
 
 class ParseableEngineSpec(BaseEngineSpec):
+    """Engine spec for Parseable log analytics database."""
+
     engine = "parseable"
     engine_name = "Parseable"
 
-    # Use same expressions as SQLAlchemy dialect for consistency
     _time_grain_expressions = {
         None: "{col}",
         TimeGrain.SECOND: "date_trunc('second', {col})",
@@ -71,7 +73,7 @@ def alter_new_orm_column(cls, orm_col: TableColumn) -> None:
             orm_col.is_dttm = True
 
     @classmethod
-    def get_extra_params(cls, database: "Database") -> dict[str, Any]:
+    def get_extra_params(cls, database: Database) -> dict[str, Any]:
         """Additional parameters for Parseable connections."""
         return {
             "engine_params": {

diff --git a/tests/unit_tests/db_engine_specs/test_parseable.py b/tests/unit_tests/db_engine_specs/test_parseable.py
@@ -72,6 +72,6 @@ def test_convert_dttm(
     """
     DB Eng Specs (parseable): Test conversion to date time
     """
-    from superset.db_engine_specs.parseable import ParseableEngineSpec as spec
+    from superset.db_engine_specs.parseable import ParseableEngineSpec
 
-    assert_convert_dttm(spec, target_type, expected_result, dttm)
+    assert_convert_dttm(ParseableEngineSpec, target_type, expected_result, dttm)