implemented feedback

apache · Sep 8, 2022 · c9a8954 · c9a8954
1 parent 4b921a5
commit c9a8954
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/Footer/index.tsx
@@ -23,14 +23,14 @@ import { useSingleViewResource } from 'src/views/CRUD/hooks';
 import withToasts from 'src/components/MessageToasts/withToasts';
 import { DatasetObject } from '../types';
 
-interface FooterObject {
+interface FooterProps {
   url: string;
   addDangerToast: () => void;
   datasetObject?: Partial<DatasetObject> | null;
   onDatasetAdd?: (dataset: DatasetObject) => void;
 }
 
-function Footer({ url, datasetObject, addDangerToast }: FooterObject) {
+function Footer({ url, datasetObject, addDangerToast }: FooterProps) {
   const { createResource } = useSingleViewResource<Partial<DatasetObject>>(
     'dataset',
     t('dataset'),

diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx
@@ -272,17 +272,17 @@ export default function LeftPanel({
           </Form>
           <div className="options-list" data-test="options-list">
             {!refresh &&
-              tableOptions.map((o, i) => (
+              tableOptions.map((option, i) => (
                 <div
                   className={
                     selectedTable === i ? 'options-highlighted' : 'options'
                   }
                   key={i}
                   role="button"
                   tabIndex={0}
-                  onClick={() => setTable(o.value, i)}
+                  onClick={() => setTable(option.value, i)}
                 >
-                  {o.label}
+                  {option.label}
                 </div>
               ))}
           </div>