Skip to content

Commit

Permalink
fix: re-enable cypress checks (#32008)
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch authored Jan 30, 2025
1 parent 732de4a commit b12f515
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 8 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
*.swp
__pycache__

.aider.*
.local
.cache
.bento*
Expand Down
1 change: 1 addition & 0 deletions scripts/cypress_run.py
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def run_cypress_for_test_file(
f"--browser {browser} "
f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME} "
f"--ci-build-id {build_id} "
f"--wait-for-missing-groups "
f"-- {chrome_flags}"
)
else:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -599,7 +599,7 @@ describe('Drill by modal', () => {
]);
});

it.skip('Radar Chart', () => {
it('Radar Chart', () => {
testEchart('radar', 'Radar Chart', [
[182, 49],
[423, 91],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ describe('Drill to detail modal', () => {
});
});

describe.skip('Bar Chart', () => {
describe('Bar Chart', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();

Expand Down Expand Up @@ -373,7 +373,7 @@ describe('Drill to detail modal', () => {
});
});

describe.skip('Area Chart', () => {
describe('Area Chart', () => {
it('opens the modal with the correct filters', () => {
testTimeChart('echarts_area');
});
Expand Down Expand Up @@ -407,7 +407,7 @@ describe('Drill to detail modal', () => {
});
});

describe.skip('World Map', () => {
describe('World Map', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();

Expand Down Expand Up @@ -567,7 +567,7 @@ describe('Drill to detail modal', () => {
});
});

describe.skip('Radar Chart', () => {
describe('Radar Chart', () => {
it('opens the modal with the correct filters', () => {
interceptSamples();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ describe('Horizontal FilterBar', () => {
validateFilterNameOnDashboard(testItems.topTenChart.filterColumn);
});

it.skip('should spot changes in "more filters" and apply their values', () => {
it('should spot changes in "more filters" and apply their values', () => {
cy.intercept(`/api/v1/chart/data?form_data=**`).as('chart');
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
Expand Down Expand Up @@ -204,7 +204,7 @@ describe('Horizontal FilterBar', () => {
);
});

it.skip('should focus filter and open "more filters" programmatically', () => {
it('should focus filter and open "more filters" programmatically', () => {
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
{ name: 'test_2', column: 'country_code', datasetId: 2 },
Expand All @@ -231,7 +231,7 @@ describe('Horizontal FilterBar', () => {
cy.get('.ant-select-focused').should('be.visible');
});

it.skip('should show tag count and one plain tag on focus and only count on blur in select ', () => {
it('should show tag count and one plain tag on focus and only count on blur in select ', () => {
prepareDashboardFilters([
{ name: 'test_1', column: 'country_name', datasetId: 2 },
]);
Expand Down

0 comments on commit b12f515

Please sign in to comment.