update proptypes

apache · Sep 5, 2018 · 751eef5 · 751eef5
1 parent 0b66d36
commit 751eef5
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/superset/assets/src/visualizations/PairedTTest/PairedTTest.jsx b/superset/assets/src/visualizations/PairedTTest/PairedTTest.jsx
@@ -2,14 +2,14 @@
 import PropTypes from 'prop-types';
 import ReactDOM from 'react-dom';
 import React from 'react';
-import TTestTable from './TTestTable';
+import TTestTable, { dataPropType } from './TTestTable';
 import './PairedTTest.css';
 
 const propTypes = {
   className: PropTypes.string,
   metrics: PropTypes.arrayOf(PropTypes.string).isRequired,
-  groups: PropTypes.array.isRequired,
-  data: PropTypes.object.isRequired,
+  groups: PropTypes.arrayOf(PropTypes.string).isRequired,
+  data: PropTypes.objectOf(dataPropType).isRequired,
   alpha: PropTypes.number,
   liftValPrec: PropTypes.number,
   pValPrec: PropTypes.number,
@@ -67,6 +67,8 @@ function adaptor(slice, payload) {
     significance_level: alpha,
   } = formData;
 
+  console.log('groups', groups, payload.data);
+
   ReactDOM.render(
     <PairedTTest
       metrics={metrics}

diff --git a/superset/assets/src/visualizations/PairedTTest/TTestTable.jsx b/superset/assets/src/visualizations/PairedTTest/TTestTable.jsx
@@ -3,10 +3,18 @@ import React from 'react';
 import { Table, Tr, Td, Thead, Th } from 'reactable';
 import PropTypes from 'prop-types';
 
+export const dataPropType = PropTypes.arrayOf(PropTypes.shape({
+  group: PropTypes.arrayOf(PropTypes.string),
+  values: PropTypes.arrayOf(PropTypes.shape({
+    x: PropTypes.number,
+    y: PropTypes.number,
+  })),
+}));
+
 const propTypes = {
   metric: PropTypes.string.isRequired,
-  groups: PropTypes.array.isRequired,
-  data: PropTypes.array.isRequired,
+  groups: PropTypes.arrayOf(PropTypes.string).isRequired,
+  data: dataPropType.isRequired,
   alpha: PropTypes.number,
   liftValPrec: PropTypes.number,
   pValPrec: PropTypes.number,