enumerate vizTypes and pieLabelType

apache · Sep 13, 2018 · 4c45f5f · 4c45f5f
1 parent dfab7e3
commit 4c45f5f
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/superset/assets/src/visualizations/nvd3/NVD3Vis.js b/superset/assets/src/visualizations/nvd3/NVD3Vis.js
@@ -32,7 +32,7 @@ import {
   boxPlotValueType,
   bulletDataType,
   categoryAndValueXYType,
-  colorObjectType,
+  rgbObjectType,
   numericXYType,
   numberOrAutoType,
   stringOrObjectWithLabelType,
@@ -109,7 +109,21 @@ const propTypes = {
   showLegend: PropTypes.bool,
   showMarkers: PropTypes.bool,
   useRichTooltip: PropTypes.bool,
-  vizType: PropTypes.string,
+  vizType: PropTypes.oneOf([
+    'area',
+    'bar',
+    'box_plot',
+    'bubble',
+    'bullet',
+    'compare',
+    'column',
+    'dist_bar',
+    'line',
+    'line_multi',
+    'time_pivot',
+    'pie',
+    'dual_line',
+  ]),
   xAxisFormat: PropTypes.string,
   xAxisLabel: PropTypes.string,
   xAxisShowMinMax: PropTypes.bool,
@@ -139,7 +153,13 @@ const propTypes = {
   // 'pie' only
   isDonut: PropTypes.bool,
   isPieLabelOutside: PropTypes.bool,
-  pieLabelType: PropTypes.string,
+  pieLabelType: PropTypes.oneOf([
+    'key',
+    'value',
+    'percent',
+    'key_value',
+    'key_percent',
+  ]),
   showLabels: PropTypes.bool,
   // 'area' only
   areaStackedStyle: PropTypes.string,
@@ -150,7 +170,7 @@ const propTypes = {
   yField: stringOrObjectWithLabelType,
   sizeField: stringOrObjectWithLabelType,
   // time-pivot only
-  baseColor: colorObjectType,
+  baseColor: rgbObjectType,
 };
 
 const NOOP = () => {};

diff --git a/superset/assets/src/visualizations/nvd3/PropTypes.js b/superset/assets/src/visualizations/nvd3/PropTypes.js
@@ -13,7 +13,7 @@ export const stringOrObjectWithLabelType = PropTypes.oneOfType([
   }),
 ]);
 
-export const colorObjectType = PropTypes.shape({
+export const rgbObjectType = PropTypes.shape({
   r: PropTypes.number.isRequired,
   g: PropTypes.number.isRequired,
   b: PropTypes.number.isRequired,