Remove limiting from xy chart, expose chart to SQL Lab

apache · Feb 5, 2018 · 1f2e61c · 1f2e61c
1 parent 1f54180
commit 1f2e61c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/superset/assets/javascripts/explore/stores/visTypes.js b/superset/assets/javascripts/explore/stores/visTypes.js
@@ -156,25 +156,14 @@ export const visTypes = {
 
   line_xy: {
     label: t('XY - Line Chart'),
+    showOnExplore: true,
     controlPanelSections: [
-      {
-        label: t('Axis Options'),
-        description: t('Select which columns or metrics to plot'),
-        expanded: true,
-        controlSetRows: [
-          ['columns_and_metrics_x'],
-          ['columns_and_metrics_y'],
-          ['slice_by'],
-        ],
-      },
       {
         label: t('GROUP BY'),
         description: t('Use this section if you want a query that aggregates'),
         controlSetRows: [
           ['groupby'],
           ['metrics'],
-          ['limit', 'timeseries_limit_metric'],
-          ['order_desc', null],
         ],
       },
       {
@@ -190,6 +179,16 @@ export const visTypes = {
           ['row_limit'],
         ],
       },
+      {
+        label: t('Axis Options'),
+        description: t('Select which columns or metrics from the query to plot'),
+        expanded: true,
+        controlSetRows: [
+          ['columns_and_metrics_x'],
+          ['columns_and_metrics_y'],
+          ['slice_by'],
+        ],
+      },
       {
         label: t('Chart Options'),
         controlSetRows: [

diff --git a/superset/viz.py b/superset/viz.py
@@ -907,8 +907,7 @@ class NVD3LineXYViz(NVD3Viz):
 
     viz_type = 'line_xy'
     verbose_name = _('XY Line Chart')
-    sort_series = False
-    is_timeseries = True
+    is_timeseries = False
 
     def query_obj(self):
         d = super(NVD3LineXYViz, self).query_obj()