[SPARK-49064][BUILD] Upgrade Kafka to 3.8.0 #47540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panbingkun
changed the title
|
Since the title is changed, could you make it |
| def cleanupLogs(): Unit = { | ||
| server.logManager.cleanupLogs() | ||
| server.logManager.invokePrivate(cleanupLogsPrivateMethod()) |
There was a problem hiding this comment.
It seems that Kafka community changed this without the official KAFKA issue.
There was a problem hiding this comment.
Yea, that's right, it was this PR that caused this change.
| @@ -117,7 +118,7 @@ class KafkaRDDSuite extends SparkFunSuite { | |||
| ) | |||
| messages.foreach { case (k, v) => | |||
| val record = new SimpleRecord(k.getBytes, v.getBytes) | |||
| log.appendAsLeader(MemoryRecords.withRecords(CompressionType.NONE, record), 0); | |||
| log.appendAsLeader(MemoryRecords.withRecords(Compression.NONE, Seq(record): _*), 0); | |||
There was a problem hiding this comment.
This is a new feature of Kafka 3.8.0 (KAFKA-7632, KIP-390).
dongjoon-hyun
approved these changes
Jul 31, 2024
There was a problem hiding this comment.
+1, LGTM for Apache Spark 4.0.0-preview2. Thank you for keeping tracking this area, @panbingkun .
panbingkun
commented
Jul 31, 2024
| @@ -447,8 +449,9 @@ class KafkaTestUtils( | |||
| sendMessages(msgs.toImmutableArraySeq) | |||
| } | |||
|
|
|||
| private val cleanupLogsPrivateMethod = PrivateMethod[LogManager](Symbol("cleanupLogs")) | |||
| def cleanupLogs(): Unit = { | |||
There was a problem hiding this comment.
In v3.8.0, the access modifier of method cleanupLogs has been changed to private
panbingkun
commented
Jul 31, 2024
| @@ -117,7 +118,7 @@ class KafkaRDDSuite extends SparkFunSuite { | |||
| ) | |||
| messages.foreach { case (k, v) => | |||
| val record = new SimpleRecord(k.getBytes, v.getBytes) | |||
| log.appendAsLeader(MemoryRecords.withRecords(CompressionType.NONE, record), 0); | |||
| log.appendAsLeader(MemoryRecords.withRecords(Compression.NONE, Seq(record): _*), 0); | |||
| } | |||
There was a problem hiding this comment.
In v3.8.0, the signature of method withRecords has been changed to MemoryRecords withRecords(Compression compression, ...)
Done. |
Thank you for your review! ❤️ |
dongjoon-hyun
approved these changes
Jul 31, 2024
|
The failed Merged to master for Apache Spark 4.0.0-preview2. |
fusheng9399
pushed a commit
to fusheng9399/spark
that referenced
this pull request
Aug 6, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `kafka` from `3.7.1` to `3.8.0`. ### Why are the changes needed? https://downloads.apache.org/kafka/3.8.0/RELEASE_NOTES.html ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47540 from panbingkun/SPARK-49064. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Aug 7, 2024
The pr aims to upgrade `kafka` from `3.7.1` to `3.8.0`. https://downloads.apache.org/kafka/3.8.0/RELEASE_NOTES.html No. Pass GA. No. Closes apache#47540 from panbingkun/SPARK-49064. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
attilapiros
pushed a commit
to attilapiros/spark
that referenced
this pull request
Oct 4, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `kafka` from `3.7.1` to `3.8.0`. ### Why are the changes needed? https://downloads.apache.org/kafka/3.8.0/RELEASE_NOTES.html ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47540 from panbingkun/SPARK-49064. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
himadripal
pushed a commit
to himadripal/spark
that referenced
this pull request
Oct 19, 2024
### What changes were proposed in this pull request? The pr aims to upgrade `kafka` from `3.7.1` to `3.8.0`. ### Why are the changes needed? https://downloads.apache.org/kafka/3.8.0/RELEASE_NOTES.html ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#47540 from panbingkun/SPARK-49064. Authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to upgrade
kafkafrom3.7.1to3.8.0.Why are the changes needed?
https://downloads.apache.org/kafka/3.8.0/RELEASE_NOTES.html
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.