[SPARK-44115][BUILD] Upgrade Apache ORC to 2.0.0 #45443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is tested during Apache ORC 2.0.0 RC0 vote. And, this PR passed here again. |
|
Could you review this PR when you have some time, please, @viirya ? |
viirya
reviewed
Mar 8, 2024
Comment on lines
+2596
to
+2602
| <dependency> | ||
| <groupId>org.apache.orc</groupId> | ||
| <artifactId>orc-format</artifactId> | ||
| <version>1.0.0</version> | ||
| <classifier>${orc.classifier}</classifier> | ||
| <scope>${orc.deps.scope}</scope> | ||
| </dependency> |
There was a problem hiding this comment.
Hmm, why do we need to exclude orc-format from orc-core and add it as a separate dependency?
There was a problem hiding this comment.
Thank you for review. It's because Apache Spark needs to control orc.classifier here. Without this, the default dependencies are pulled in.
viirya
approved these changes
Mar 8, 2024
|
Thank you so much, @viirya ! Merged to master for Apache Spark 4.0.0. |
|
Late +1 & LGTM. Thank you @dongjoon-hyun |
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? This PR aims to Upgrade Apache ORC to 2.0.0 for Apache Spark 4.0.0. Apache ORC community has 3-year support policy which is longer than Apache Spark. It's aligned like the following. - Apache ORC 2.0.x <-> Apache Spark 4.0.x - Apache ORC 1.9.x <-> Apache Spark 3.5.x - Apache ORC 1.8.x <-> Apache Spark 3.4.x - Apache ORC 1.7.x (Supported) <-> Apache Spark 3.3.x (End-Of-Support) ### Why are the changes needed? **Release Note** - https://github.com/apache/orc/releases/tag/v2.0.0 **Milestone** - https://github.com/apache/orc/milestone/20?closed=1 - apache/orc#1728 - apache/orc#1801 - apache/orc#1498 - apache/orc#1627 - apache/orc#1497 - apache/orc#1509 - apache/orc#1554 - apache/orc#1708 - apache/orc#1733 - apache/orc#1760 - apache/orc#1743 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45443 from dongjoon-hyun/SPARK-44115. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to Upgrade Apache ORC to 2.0.0 for Apache Spark 4.0.0.
Apache ORC community has 3-year support policy which is longer than Apache Spark. It's aligned like the following.
Why are the changes needed?
Release Note
Milestone
Java 21LTS orc#1498Hadoop 2dependency orc#1497ZSTDas the default compression orc#1733orc.compression.zstd.levelto 3 by default orc#1760Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.