[SPARK-35405][DOC] Submitting Applications documentation has outdated information about K8s client mode support #32551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… information about K8s client mode support
|
ok to test |
|
Test build #138560 has finished for PR 32551 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Can one of the admins verify this patch? |
dongjoon-hyun
approved these changes
May 14, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you, @o-shevchenko .
Merged to master/3.1/3.0.
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 14, 2021
… information about K8s client mode support ### What changes were proposed in this pull request? [Submitting Applications doc](https://spark.apache.org/docs/latest/submitting-applications.html#master-urls) has outdated information about K8s client mode support. It still says "Client mode is currently unsupported and will be supported in future releases".  Whereas it's already supported and [Running Spark on Kubernetes doc](https://spark.apache.org/docs/latest/running-on-kubernetes.html#client-mode) says that it's supported started from 2.4.0 and has all needed information.  Changes:  JIRA: https://issues.apache.org/jira/browse/SPARK-35405 ### Why are the changes needed? Outdated information in the doc is misleading ### Does this PR introduce _any_ user-facing change? Documentation changes ### How was this patch tested? Documentation changes Closes #32551 from o-shevchenko/SPARK-35405. Authored-by: Oleksandr Shevchenko <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit d2fbf0d) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 14, 2021
… information about K8s client mode support ### What changes were proposed in this pull request? [Submitting Applications doc](https://spark.apache.org/docs/latest/submitting-applications.html#master-urls) has outdated information about K8s client mode support. It still says "Client mode is currently unsupported and will be supported in future releases".  Whereas it's already supported and [Running Spark on Kubernetes doc](https://spark.apache.org/docs/latest/running-on-kubernetes.html#client-mode) says that it's supported started from 2.4.0 and has all needed information.  Changes:  JIRA: https://issues.apache.org/jira/browse/SPARK-35405 ### Why are the changes needed? Outdated information in the doc is misleading ### Does this PR introduce _any_ user-facing change? Documentation changes ### How was this patch tested? Documentation changes Closes #32551 from o-shevchenko/SPARK-35405. Authored-by: Oleksandr Shevchenko <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit d2fbf0d) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Thank you for your first contribution, @o-shevchenko . You are added to the Apache Spark contributor group and SPARK-35405 is assigned to you. Welcome to the Apache Spark community! |
|
Thanks a lot for your review! |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
… information about K8s client mode support ### What changes were proposed in this pull request? [Submitting Applications doc](https://spark.apache.org/docs/latest/submitting-applications.html#master-urls) has outdated information about K8s client mode support. It still says "Client mode is currently unsupported and will be supported in future releases".  Whereas it's already supported and [Running Spark on Kubernetes doc](https://spark.apache.org/docs/latest/running-on-kubernetes.html#client-mode) says that it's supported started from 2.4.0 and has all needed information.  Changes:  JIRA: https://issues.apache.org/jira/browse/SPARK-35405 ### Why are the changes needed? Outdated information in the doc is misleading ### Does this PR introduce _any_ user-facing change? Documentation changes ### How was this patch tested? Documentation changes Closes apache#32551 from o-shevchenko/SPARK-35405. Authored-by: Oleksandr Shevchenko <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit d2fbf0d) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Submitting Applications doc has outdated information about K8s client mode support.
It still says "Client mode is currently unsupported and will be supported in future releases".
Whereas it's already supported and Running Spark on Kubernetes doc says that it's supported started from 2.4.0 and has all needed information.
Changes:
JIRA: https://issues.apache.org/jira/browse/SPARK-35405
Why are the changes needed?
Outdated information in the doc is misleading
Does this PR introduce any user-facing change?
Documentation changes
How was this patch tested?
Documentation changes