[SPARK-34701][SQL] Introduce CommandWithAnalyzedChildren for a command to have its children only analyzed but not optimized #32041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #136874 has finished for PR 32041 at commit
|
cloud-fan
reviewed
Apr 5, 2021
| trait CommandWithAnalyzedChildren extends Command { | ||
| def childrenToAnalyze: Seq[LogicalPlan] = Nil | ||
|
|
||
| override final def children: Seq[LogicalPlan] = childrenToAnalyze.filter(!_.analyzed) |
There was a problem hiding this comment.
This is a bit risky. Some analyzer rules may want to transform the child even if it's analyzed.
|
Closing in favor of #32032. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Note that this PR proposes an alternate solution to #32032.
This PR proposes to introduce the
CommandWithAnalyzedChildrentrait such that a command that extends the trait will have its children only analyzed, but not optimized. This can be useful if a logical plan has children where they need to be only analyzed, but not optimized - e.g.,CREATE VIEWorCACHE TABLE AS. This also addresses the issue found in #31933.This PR also updates
CreateViewCommandandCacheTableAsSelectto use the new trait such that their children are only analyzed.Why are the changes needed?
To address the issue where the plan is unnecessarily re-analyzed in
CreateViewCommand.Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests should cover the changes.