Skip to content

Commit

Permalink
[SPARK-34764][UI][FOLLOW-UP] Fix indentation and missing arguments fo…
Browse files Browse the repository at this point in the history
…r JavaScript linter

### What changes were proposed in this pull request?

This PR is a followup of #32436 which broke JavaScript linter. There was a logical conflict - the linter was added after the last successful test run in that PR.

```
added 118 packages in 1.482s

/__w/spark/spark/core/src/main/resources/org/apache/spark/ui/static/executorspage.js
   34:41  error  'type' is defined but never used. Allowed unused args must match /^_ignored_.*/u  no-unused-vars
   34:47  error  'row' is defined but never used. Allowed unused args must match /^_ignored_.*/u   no-unused-vars
   35:1   error  Expected indentation of 2 spaces but found 4                                      indent
   36:1   error  Expected indentation of 4 spaces but found 7                                      indent
   37:1   error  Expected indentation of 2 spaces but found 4                                      indent
   38:1   error  Expected indentation of 4 spaces but found 7                                      indent
   39:1   error  Expected indentation of 2 spaces but found 4                                      indent
  556:1   error  Expected indentation of 14 spaces but found 16                                    indent
  557:1   error  Expected indentation of 14 spaces but found 16                                    indent
```

### Why are the changes needed?

To recover the build

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

Manually tested:

```bash
 ./dev/lint-js
lint-js checks passed.
```

Closes #32541 from HyukjinKwon/SPARK-34764-followup.

Authored-by: Hyukjin Kwon <[email protected]>
Signed-off-by: Kousuke Saruta <[email protected]>
  • Loading branch information
HyukjinKwon authored and sarutak committed May 14, 2021
1 parent b6a0a7e commit f7af9ab
Showing 1 changed file with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ function getThreadDumpEnabled() {
return threadDumpEnabled;
}

function formatLossReason(removeReason, type, row) {
if (removeReason) {
return removeReason
} else {
return ""
}
function formatLossReason(removeReason) {
if (removeReason) {
return removeReason
} else {
return ""
}
}

function formatStatus(status, type, row) {
Expand Down Expand Up @@ -553,8 +553,8 @@ $(document).ready(function () {
}
},
{
data: 'removeReason',
render: formatLossReason
data: 'removeReason',
render: formatLossReason
}
],
"order": [[0, "asc"]],
Expand Down

0 comments on commit f7af9ab

Please sign in to comment.