Skip to content

Commit

Permalink
Address comment in AggregatePushDownUtils to remove unnecessary state…
Browse files Browse the repository at this point in the history
…ments
  • Loading branch information
c21 committed Oct 16, 2021
1 parent 73627ed commit 1f36f12
Showing 1 changed file with 3 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,6 @@ object AggregatePushDownUtils {
return None
}

aggregation.groupByColumns.foreach { col =>
if (col.fieldNames.length != 1) return None
finalSchema = finalSchema.add(getStructFieldForCol(col))
}

aggregation.aggregateExpressions.foreach {
case max: Max =>
if (!processMinOrMax(max)) return None
Expand Down Expand Up @@ -126,9 +121,9 @@ object AggregatePushDownUtils {
* This is used for columnar reader.
*/
def convertAggregatesRowToBatch(
aggregatesAsRow: InternalRow,
aggregatesSchema: StructType,
offHeap: Boolean): ColumnarBatch = {
aggregatesAsRow: InternalRow,
aggregatesSchema: StructType,
offHeap: Boolean): ColumnarBatch = {
val converter = new RowToColumnConverter(aggregatesSchema)
val columnVectors = if (offHeap) {
OffHeapColumnVector.allocateColumns(1, aggregatesSchema)
Expand Down

0 comments on commit 1f36f12

Please sign in to comment.