Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-11318: Introduce unit testing for AssertTool #2699

Merged
merged 6 commits into from
Sep 10, 2024
Merged

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Sep 9, 2024

https://issues.apache.org/jira/browse/SOLR-11318

Description

Introduce unit testing to assert tool

Solution

Use code already written by @gerlowskija that never made it to a commit!

Tests

yeah, thats what this is!

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

Copy link
Contributor

@gerlowskija gerlowskija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just how I would've written it myself!

@epugh epugh merged commit fc6ac61 into apache:main Sep 10, 2024
2 of 3 checks passed
epugh added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants