Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-16254: Clarify when a create needs to be run on the same server as Solr. #2698

Merged
merged 5 commits into from
Sep 11, 2024
Merged

SOLR-16254: Clarify when a create needs to be run on the same server as Solr. #2698

merged 5 commits into from
Sep 11, 2024

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Sep 8, 2024 •
edited
Loading

https://issues.apache.org/jira/browse/SOLR-16254

Description

Extend help docs to clarify that if you create a core you need to run it on the server.

Solution

i couldn't find a good way to check this to prevent it from happening, which would have been nicer. so tried to just add better help docs.

Tests

manual testing

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation)
  • I have developed this patch against the main branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Reference Guide

janhoy
janhoy approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@epugh epugh merged commit 14c9575 into apache:main Sep 11, 2024
4 checks passed
epugh added a commit that referenced this pull request Sep 11, 2024
@epugh
SOLR-16254: Clarify when a create needs to be run on the same server …
58283d2 
…as Solr. (#2698)

* Introduce new header for help text to clarify when you must run on the same server as solr.

* small formatting tweak to improve whitespace in cli output

* use similar text for similar meaning

(cherry picked from commit 14c9575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhoy janhoy janhoy approved these changes

Assignees
No one assigned
Labels
cat:cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epugh @janhoy