SOLR-17429, SOLR-17338: Use stderr for SolrCLI deprecation logs #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoustonPutman
changed the title
HoustonPutman
changed the title
HoustonPutman
added a commit
that referenced
this pull request
Aug 30, 2024
(cherry picked from commit 26d00c3)
HoustonPutman
added a commit
that referenced
this pull request
Aug 30, 2024
(cherry picked from commit 26d00c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tools that parse the output of the Solr CLI will be broken with the new deprecation notices. Moving the deprecation notices to stderr instead of stdout will fix this.
Unfortunately we can't make the Deprecation Handler:
because
Option.toDeprecatedString()is package protected for some reason. Because of this, I've basically copied the method until a release of CommonsCLI will make that method public. (or even make stderr the default, which it likely should be)