Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify SymbolToken to InsertColumnToken and add parser-result for sha… #772

Merged
merged 3 commits into from
Apr 28, 2018
Merged

modify SymbolToken to InsertColumnToken and add parser-result for sha… #772

merged 3 commits into from
Apr 28, 2018

Conversation

tristaZero
Copy link
Contributor

…rding-core.

Fixes #758 .

Changes proposed in this pull request:

  • Modify SymbolToken to InsertColumnToken
  • Add some sql-parser-results of insert without colums for sharding-core.

@codecov-io
Copy link

codecov-io commented Apr 28, 2018

Codecov Report

Merging #772 into dev will increase coverage by 0.03%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #772      +/-   ##
==========================================
+ Coverage   64.46%   64.49%   +0.03%     
==========================================
  Files         484      484              
  Lines        9547     9547              
  Branches     1571     1571              
==========================================
+ Hits         6154     6157       +3     
+ Misses       3059     3053       -6     
- Partials      334      337       +3
Impacted Files Coverage Δ
...c/core/parsing/parser/token/InsertColumnToken.java 0% <ø> (ø)
...rsing/parser/clause/InsertColumnsClauseParser.java 96.87% <100%> (ø) ⬆️
...io/shardingjdbc/core/rewrite/SQLRewriteEngine.java 96.8% <75%> (ø) ⬆️
.../internal/config/ConfigurationListenerManager.java 75% <0%> (+3.57%) ⬆️
...ternal/state/instance/InstanceListenerManager.java 42.3% <0%> (+3.84%) ⬆️
...al/state/datasource/DataSourceListenerManager.java 54.54% <0%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9164b...b1aa0a2. Read the comment docs.

@terrymanu terrymanu merged commit 3d18ff9 into apache:dev Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants