Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The second usage of metadata #771

Merged
merged 16 commits into from
Apr 28, 2018
Merged

The second usage of metadata #771

merged 16 commits into from
Apr 28, 2018

Conversation

tristaZero
Copy link
Contributor

Fixes #758 .

Changes proposed in this pull request:

  • Support insert without columns.
  • Support insert without columns and generating generated-key.
  • Add some tests and expected files for this usage.
  • Modify some tests.

@codecov-io
Copy link

Codecov Report

Merging #771 into dev will increase coverage by 0.2%.
The diff coverage is 97.01%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #771     +/-   ##
=========================================
+ Coverage   64.28%   64.49%   +0.2%     
=========================================
  Files         483      484      +1     
  Lines        9506     9547     +41     
  Branches     1562     1571      +9     
=========================================
+ Hits         6111     6157     +46     
+ Misses       3060     3053      -7     
- Partials      335      337      +2
Impacted Files Coverage Δ
...dingjdbc/core/parsing/parser/token/ItemsToken.java 66.66% <ø> (ø) ⬆️
...ingjdbc/core/parsing/parser/token/SymbolToken.java 0% <0%> (ø)
.../parser/dialect/oracle/sql/OracleInsertParser.java 100% <100%> (ø) ⬆️
...ng/parser/dialect/mysql/sql/MySQLInsertParser.java 100% <100%> (ø) ⬆️
...r/dialect/sqlserver/sql/SQLServerInsertParser.java 100% <100%> (ø) ⬆️
...rsing/parser/clause/InsertColumnsClauseParser.java 96.87% <100%> (+2.75%) ⬆️
...ng/parser/sql/dml/insert/AbstractInsertParser.java 90.9% <100%> (+0.9%) ⬆️
...parsing/parser/sql/dml/insert/InsertStatement.java 62.5% <100%> (+22.5%) ⬆️
...ing/parser/sql/dml/insert/InsertParserFactory.java 83.33% <100%> (ø) ⬆️
...dialect/postgresql/sql/PostgreSQLInsertParser.java 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4cab8...6612b17. Read the comment docs.

@terrymanu terrymanu merged commit 9f9164b into apache:dev Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants