Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PreviewHandler #25941

Merged
merged 2 commits into from
May 30, 2023
Merged

Refactor PreviewHandler #25941

merged 2 commits into from
May 30, 2023

Conversation

yx9o
Copy link
Contributor

@yx9o yx9o commented May 29, 2023 •
edited
Loading

For #25868 , Refactor PreviewHandler.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@yx9o yx9o added this to the 5.4.0 milestone May 29, 2023
@TeslaCN TeslaCN requested a review from RaigorJiang May 30, 2023 02:35
@RaigorJiang RaigorJiang merged commit 0f6bb7e into apache:master May 30, 2023
@yx9o yx9o deleted the dev-2586803 branch May 30, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaigorJiang RaigorJiang RaigorJiang approved these changes

Assignees
No one assigned
Labels
feature: DistSQL type: refactor
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yx9o @RaigorJiang