Support for boolean primary MySQL queries #25424

kanha-gupta · 2023-04-30T15:15:58Z

Changes proposed in this pull request:

Before committing this PR, I'm sure that I have checked the following options:

My code follows the code of conduct of this project.
I have self-reviewed the commit code.
I have (or in comment I request) added corresponding labels for the pull request.
I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
I have made corresponding changes to the documentation.
I have added corresponding unit tests for my changes.

This reverts commit 9af038be0f4be54affd801c9ac2f6750db883377.

kanha-gupta · 2023-04-30T16:56:33Z

@strongduanmu Respected sir, This PR works well (SQLNodeConverterEngineIT and XML tests are successful) but I am getting a maven error :
Error: Tests run: 265, Failures: 0, Errors: 8, Skipped: 0, Time elapsed: 6.686 s <<< FAILURE! - in org.apache.shardingsphere.test.it.rewrite.engine.scenario.EncryptSQLRewriterIT
Error: assertRewrite{SQLRewriteEngineTestParameters}[145] Time elapsed: 0.022 s <<< ERROR!
org.apache.shardingsphere.encrypt.exception.syntax.UnsupportedEncryptSQLException: The SQL clause IS NULL is unsupported in encrypt rule.

what is encrypt rule & how to add support for 'IS NULL' ?
I did this PR for code demonstration

kanha-gupta · 2023-05-01T00:48:00Z

@strongduanmu Queries in Update.xml test file is giving the above error which follows scenario/encrypt/config/query-with-cipher.yaml configuration
while running EncryptSQLRewriterIT.java file.
can you please suggest whether changes are required in XML Files or In Code files or YAML file ?

...deration/optimizer/converter/segment/expression/impl/BinaryOperationExpressionConverter.java

...java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java

test/it/parser/src/main/resources/sql/supported/dml/select.xml

…ion-queries

kanha-gupta · 2023-05-04T12:56:36Z

@strongduanmu Please review, All database parsers have been optimised now.
Thank you

strongduanmu · 2023-05-05T00:05:01Z

@strongduanmu Please review, All database parsers have been optimised now. Thank you

@kanha-gupta Good job, I will review this pr again.

strongduanmu · 2023-05-05T02:22:43Z

...rc/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/EncryptConditionEngine.java

@@ -77,6 +77,8 @@ public final class EncryptConditionEngine {
        SUPPORTED_COMPARE_OPERATOR.add("<=");
        SUPPORTED_COMPARE_OPERATOR.add("IS");


Please remove useless IS operator.

strongduanmu · 2023-05-05T02:33:38Z

...java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java

@@ -441,7 +446,9 @@ public final ASTNode visitBooleanPrimary(final BooleanPrimaryContext ctx) {
            ExpressionSegment right = new LiteralExpressionSegment(ctx.IS().getSymbol().getStopIndex() + 2, ctx.stop.getStopIndex(), rightText);
            String text = ctx.start.getInputStream().getText(new Interval(ctx.start.getStartIndex(), ctx.stop.getStopIndex()));
            ExpressionSegment left = (ExpressionSegment) visit(ctx.booleanPrimary());
-            String operator = "IS";
+            if (null != ctx.NULL()) {
+                right = null;


Can you refer https://github.com/polardb/polardbx-sql/blob/cdd976850bdfc3264dff279198b6b06eb8641fbe/polardbx-optimizer/src/main/java/com/alibaba/polardbx/optimizer/parse/visitor/FastSqlToCalciteNodeVisitor.java#L5346-L5350 to extract is and is not as an operator, and keep the right to LiteralExpressionSegment?

Surely sir, I tried it on my local system.
Keeping right to LiteralExpressionSegment is causing double NULL values ->
IS NULL NULL where :
IS NULL -> postfix operator
NULL -> LiteralExpressionSegment
Can you please suggest the fix for this ?

You can modify is null operator to is operator, is not null operator to is not operator.

@strongduanmu Sir, I tried it. The problem I am encountering is that Calcite's SqlStdOperatorTable do not have "IS" as a function or PostFixOperator. Therefore While breaking "IS NULL" into "IS" as operator & "NULL" in right as LiteralExpressionSegment, It gives error "IS" is not supported.
Same problem is for "IS NOT NULL" as SqlStdOperatorTable doesnt support "IS NOT"

@strongduanmu Therefore Please suggest a solution for it.
Thank you

Can you refer https://github.com/polardb/polardbx-sql/blob/cdd976850bdfc3264dff279198b6b06eb8641fbe/polardbx-optimizer/src/main/java/com/alibaba/polardbx/optimizer/parse/visitor/FastSqlToCalciteNodeVisitor.java#L5346-L5350 to extract is and is not as an operator, and keep the right to LiteralExpressionSegment?

@kanha-gupta Can you take a look at this link? It provide an example to convert to sql node.

@strongduanmu Okay sir, I will update you with the progress :)

@strongduanmu Sir, should I just revise CodeStyle ? in the example code, operator is set when Right is instanceof SqlNullExpr. Therefore I can understand that the Logic would stay same just like this current PR ?
Thank you

strongduanmu · 2023-05-05T02:35:31Z

.../apache/shardingsphere/sql/parser/opengauss/visitor/statement/OpenGaussStatementVisitor.java

@@ -356,7 +356,7 @@ private BinaryOperationExpression createPatternMatchingOperationSegment(final AE

    private BinaryOperationExpression createBinaryOperationSegment(final AExprContext ctx, final String operator) {
        if ("IS".equalsIgnoreCase(operator)) {
-            ExpressionSegment left = (ExpressionSegment) visit(ctx.aExpr(0));
+            String ifOperator = operator;


What does ifOperator mean?

Sir, I'll rename it. The variable helps in storing & changing String values when IF conditions are met.

kanha-gupta and others added 13 commits April 27, 2023 15:09

support for Char function

0fad338

support for Weight string SQL

757a8d9

Support for Char & weight string Function

2bdf6c0

Revert "Support for Substring function"

500d9eb

This reverts commit 9af038be0f4be54affd801c9ac2f6750db883377.

support for Char function

dc5b165

support for Weight string SQL

cecddb7

Support for Char & weight string Function

224ffa6

Revert "Support for Substring function"

53da3df

This reverts commit 9af038be0f4be54affd801c9ac2f6750db883377.

restore errors

36e2eeb

Merge branch 'apache:master' into master

f8c8a07

Support for booleanPrimary

363f769

Merge branch 'master' into Expression-queries

abeeeb8

restore errors

74eccad

kanha-gupta changed the title ~~Expression queries~~ Support for boolean primary MySQL queries Apr 30, 2023

Merge branch 'apache:master' into master

54ee8dc

strongduanmu added type: enhancement db: MySQL feature: SQL federation labels May 2, 2023

strongduanmu added this to the 5.4.0 milestone May 2, 2023

strongduanmu requested changes May 2, 2023

View reviewed changes

...deration/optimizer/converter/segment/expression/impl/BinaryOperationExpressionConverter.java Outdated Show resolved Hide resolved

...java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java Show resolved Hide resolved

strongduanmu requested changes May 3, 2023

View reviewed changes

...java/org/apache/shardingsphere/sql/parser/mysql/visitor/statement/MySQLStatementVisitor.java Show resolved Hide resolved

strongduanmu requested changes May 3, 2023

View reviewed changes

test/it/parser/src/main/resources/sql/supported/dml/select.xml Outdated Show resolved Hide resolved

kanha-gupta and others added 4 commits May 3, 2023 10:22

restore errors

0dd3956

Merge branch 'apache:master' into master

9f4bbe9

Merge branch 'master' into Expression-queries

cc95efe

Merge remote-tracking branch 'origin/Expression-queries' into Express…

aa67406

…ion-queries

kanha-gupta requested a review from strongduanmu May 3, 2023 05:09

support for all database parsers

daeeacf

kanha-gupta and others added 2 commits May 4, 2023 18:00

Merge branch 'apache:master' into master

0e049e6

Merge branch 'master' into Expression-queries

be5427d

strongduanmu requested changes May 5, 2023

View reviewed changes

kanha-gupta closed this May 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for boolean primary MySQL queries #25424

Support for boolean primary MySQL queries #25424

kanha-gupta commented Apr 30, 2023 •

edited

Loading

kanha-gupta commented Apr 30, 2023 •

edited

Loading

kanha-gupta commented May 1, 2023 •

edited

Loading

kanha-gupta commented May 4, 2023

strongduanmu commented May 5, 2023

strongduanmu May 5, 2023

strongduanmu May 5, 2023

kanha-gupta May 5, 2023

strongduanmu May 5, 2023

kanha-gupta May 5, 2023

kanha-gupta May 5, 2023

strongduanmu May 5, 2023

kanha-gupta May 5, 2023

kanha-gupta May 8, 2023

strongduanmu May 5, 2023

kanha-gupta May 5, 2023 •

edited

Loading

		@@ -77,6 +77,8 @@ public final class EncryptConditionEngine {
		SUPPORTED_COMPARE_OPERATOR.add("<=");
		SUPPORTED_COMPARE_OPERATOR.add("IS");

Support for boolean primary MySQL queries #25424

Support for boolean primary MySQL queries #25424

Conversation

kanha-gupta commented Apr 30, 2023 • edited Loading

Changes proposed in this pull request:

kanha-gupta commented Apr 30, 2023 • edited Loading

kanha-gupta commented May 1, 2023 • edited Loading

kanha-gupta commented May 4, 2023

strongduanmu commented May 5, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kanha-gupta May 5, 2023 • edited Loading

Choose a reason for hiding this comment

kanha-gupta commented Apr 30, 2023 •

edited

Loading

kanha-gupta commented Apr 30, 2023 •

edited

Loading

kanha-gupta commented May 1, 2023 •

edited

Loading

kanha-gupta May 5, 2023 •

edited

Loading