Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for substring, dual, spatial function #25268

Merged
merged 15 commits into from
Apr 24, 2023
Merged

Support for substring, dual, spatial function #25268

merged 15 commits into from
Apr 24, 2023

Conversation

kanha-gupta
Copy link
Contributor

Fixes #24200

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@kanha-gupta
Copy link
Contributor Author

@strongduanmu Respected sir, Please review this.
There is one commit for each SQL test case.
substring, dual , spatial

@strongduanmu
Copy link
Member

Hi @kanha-gupta, can you merge master branch to solve code conflict?

@kanha-gupta
Copy link
Contributor Author

kanha-gupta commented Apr 23, 2023

@strongduanmu Done, please check. Code conflict is removed now

@kanha-gupta
Copy link
Contributor Author

@strongduanmu Done sir, I request you to review it :)

Copy link
Member

@strongduanmu strongduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, merged.

@strongduanmu strongduanmu merged commit 6e52731 into apache:master Apr 24, 2023
@strongduanmu
Copy link
Member

Fixes #24200

Hi @kanha-gupta, can you use Ref #24200 in next time? Fixes will close the issue.

@kanha-gupta
Copy link
Contributor Author

Fixes #24200

Hi @kanha-gupta, can you use Ref #24200 in next time? Fixes will close the issue.

Okay sir. Will do :)
Thank you

@kanha-gupta kanha-gupta deleted the queries-support branch April 24, 2023 05:26
@kanha-gupta kanha-gupta restored the queries-support branch April 24, 2023 05:26
@kanha-gupta kanha-gupta deleted the queries-support branch April 24, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GSOC 2023] Enhance SQLNodeConverterEngine to support more MySQL SQL statements
2 participants