Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1186, get connections synchronized in MEMORY_STRICTLY mode #1187

Closed
wants to merge 1 commit into from
Closed

#1186, get connections synchronized in MEMORY_STRICTLY mode #1187

wants to merge 1 commit into from

Conversation

tuohai666
Copy link
Member

Fixes #1186 .

@terrymanu
Copy link
Member

just close it, we need separate create connection and create statement

@terrymanu terrymanu closed this Aug 26, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4833

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 22.726%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sharding-proxy/src/main/java/io/shardingsphere/proxy/backend/jdbc/execute/stream/MemoryStrictlyExecuteEngine.java 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-namespace/src/main/java/io/shardingsphere/jdbc/orchestration/spring/datasource/OrchestrationMasterSlaveDataSourceFactoryBean.java 1 66.67%
Totals Coverage Status
Change from base Build 4832: 0.02%
Covered Lines: 8114
Relevant Lines: 35703
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tuohai666 @terrymanu @coveralls