Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sedona 173 delta lake tests #696

Closed
wants to merge 2 commits into from

Conversation

Imbruced
Copy link
Member

@Imbruced Imbruced commented Oct 1, 2022

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

What changes were proposed in this PR?

delta lakes tests in scala and python notebook with examples how to use geospatial functions with delta lake.

How was this patch tested?

Unit tests

@Imbruced Imbruced force-pushed the SEDONA-173-delta-lake-tests branch 2 times, most recently from f2b10aa to 1c32c39 Compare October 23, 2022 22:19
@Kimahriman
Copy link
Contributor

Just my opinion, this seems like the only thing this is really "testing" is if Delta supports user-defined types, which is more of a thing for the Delta repo than this one, and doesn't really seem like it makes sense as a new module to add. But this makes perfect sense to just be an example notebook on how you can work with geometries natively with Delta.

@Imbruced
Copy link
Member Author

@Kimahriman I also agree, the main reason why I created additional module was to figure out later if we can add by default writing to delta in geoparquet data format.

@Imbruced
Copy link
Member Author

@jiayuasu what do you think about that ? MAybe placing which delta version works with which scala, spark and jackson is goo enough ?

@jiayuasu
Copy link
Member

@Imbruced Yes, I agree with @Kimahriman . The only purpose of this module is testing. Can you (1) place the Scala/Java part to /example/ folder (2) keep the Python notebook in /binder/ ?

@Imbruced Imbruced force-pushed the SEDONA-173-delta-lake-tests branch from 8f3f395 to a0e1f2e Compare November 13, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants