-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve] improve hazelcast joiner, lite node can't be election as master #8261
Conversation
overwrite the default behavoir, use overwrite |
73bccaf
to
a24af69
Compare
tested in my company with K8S deploy, it can work well |
8d7115b
to
5e56bc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you update
Line 52 in 1a5feb1
public class SeaTunnelEngineClusterRoleTest { |
Add test about TcpIp and multicast. |
} | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not return super.createJoiner(node);
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Purpose of this pull request
close #8248
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.