Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] improve hazelcast joiner, lite node can't be election as master #8261

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

close #8248

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the Zeta label Dec 10, 2024
@liunaijie liunaijie force-pushed the fix/hazelcast_joiner branch 2 times, most recently from 73bccaf to a24af69 Compare December 10, 2024 04:39
@liunaijie
Copy link
Member Author

tested in my company with K8S deploy, it can work well

@liunaijie liunaijie force-pushed the fix/hazelcast_joiner branch from 8d7115b to 5e56bc4 Compare December 11, 2024 07:19
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update

to test this situation?

@liunaijie
Copy link
Member Author

}
return null;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not return super.createJoiner(node);?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has cover all cases. Same like original implement.

image

@hailin0 hailin0 merged commit a139595 into apache:dev Dec 13, 2024
7 checks passed
@liunaijie liunaijie deleted the fix/hazelcast_joiner branch December 16, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Zeta] Separated Cluster deploy has some issue on K8S
3 participants