Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][dist]add UT class name check #8182

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

hawk9821
Copy link
Contributor

Purpose of this pull request

The unit test class is named improperly, resulting in CI not running UT case.

org.opentest4j.AssertionFailedError: UT class does not conform to the naming convention, must should be start with 'Test' or end with 'Test' or end with 'Tests' or end with 'TestCase'.
 E:\work\seatunnel\seatunnel-connectors-v2\connector-console\src\test\java\org\apache\seatunnel\connectors\seatunnel\console\sink\ConsoleSinkWriterIT.java ==> 
Expected :0
Actual   :1
2b64ec9eecf83f370d035d1f405ab2c

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hawk9821 !

@hailin0 hailin0 merged commit 9cf4192 into apache:dev Dec 2, 2024
4 checks passed
@hawk9821 hawk9821 deleted the ut_class_name_check branch December 2, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants